test: stabilize get-webpage cases in TestHiveStore#303
Open
Jack-LuoHongyi wants to merge 1 commit intoapache:masterfrom
Open
test: stabilize get-webpage cases in TestHiveStore#303Jack-LuoHongyi wants to merge 1 commit intoapache:masterfrom
Jack-LuoHongyi wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gora-hive#testGetPartitions,#testGetWebPage,#testGetWebPageDefaultFieldsRoot Cause
Hive schema and row visibility are eventually consistent. Running lookups immediately after writes can throw
QueryParserExceptionor return null rows, and NonDex order perturbations made the race more likely.Fix
Introduce
awaitWebPageSchemato retry reads until the schema exists and the target URL returns a non-null page, recreating the store when parser errors occur. Reuse the helper across the three getWebPage tests so they rely on deterministic URL inputs and wait for visibility to stabilize.Validation
mvn -pl gora-hive -Dtest=org.apache.gora.hive.store.TestHiveStore#testGetPartitions testmvn -pl gora-hive -Dtest=org.apache.gora.hive.store.TestHiveStore#testGetWebPage testmvn -pl gora-hive -Dtest=org.apache.gora.hive.store.TestHiveStore#testGetWebPageDefaultFields testedu.illinois:nondex-maven-pluginRisk
Low. The changes only improve test determinism and visibility polling without touching production code paths.