test: stabilize get cases in TestHiveStore#302
Open
Jack-LuoHongyi wants to merge 1 commit intoapache:masterfrom
Open
test: stabilize get cases in TestHiveStore#302Jack-LuoHongyi wants to merge 1 commit intoapache:masterfrom
Jack-LuoHongyi wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gora-hive#testGet,#testGetNested,#testGetWithFields,#testObjectFieldValue,#testGetNonExistingRoot Cause
Hive metadata and row visibility propagate asynchronously. Running lookups immediately after writes could surface parser exceptions or null results in certain runs. The inherited defaults also exercised the recursive
bossfield and randomized primary keys, which occasionally triggered errors when simulated with theedu.illinois:nondex-maven-pluginorder-perturbation plugin.Fix
Introduce
awaitEmployeeSchemato poll until the schema and requested row are observable, closing and recreatingemployeeStoreon parser errors. Refactor the five get-oriented tests to use the helper, switch to stable keys such asemployee-1234567890, and avoid expectations on recursive fields while preserving the original assertions.Validation
mvn -pl gora-hive -Dtest=org.apache.gora.hive.store.TestHiveStore#testGet testmvn -pl gora-hive -Dtest=org.apache.gora.hive.store.TestHiveStore#testGetNested testmvn -pl gora-hive -Dtest=org.apache.gora.hive.store.TestHiveStore#testGetWithFields testmvn -pl gora-hive -Dtest=org.apache.gora.hive.store.TestHiveStore#testObjectFieldValue testmvn -pl gora-hive -Dtest=org.apache.gora.hive.store.TestHiveStore#testGetNonExisting testedu.illinois:nondex-maven-pluginRisk
Low. Changes add polling safeguards and deterministic inputs without touching production paths.