test: make hive.store.TestHiveStore.testAutoCreateSchema deterministic#298
Open
Jack-LuoHongyi wants to merge 1 commit intoapache:masterfrom
Open
test: make hive.store.TestHiveStore.testAutoCreateSchema deterministic#298Jack-LuoHongyi wants to merge 1 commit intoapache:masterfrom
Jack-LuoHongyi wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
test: make org.apache.gora.hive.store.TestHiveStore deterministicSummary
gora-hiveorg.apache.gora.hive.store.TestHiveStore#testAutoCreateSchemaRoot Cause
After auto-creating the table, Hive metastore visibility may lag briefly. A direct
schemaExists()check immediately after the first write can observe stale metadata.Fix
assertAutoCreateSchemaonly. Poll up to 5 seconds (100 ms interval) withflush()between attempts untilschemaExists()is observed, then assert. The timeout balances reliability and runtime overhead.assertSchemaExistsas a direct existence check and handle bothEmployeeandWebPageschema names (base tests callassertSchemaExists("WebPage")inDataStoreTestBase#testTruncateSchema).employeeStore.getSchemaName()to remain robust to mapping changes.Validation
mvn -pl gora-hive -Dtest=org.apache.gora.hive.store.TestHiveStore#testAutoCreateSchema testRisk
Low. Adds a bounded wait in a single test path; preserves validation semantics.