Fix flaky test TestIgniteStore#testQueryKeyRange in gora-ignite#297
Closed
ndeneh93 wants to merge 4 commits intoapache:masterfrom
Closed
Fix flaky test TestIgniteStore#testQueryKeyRange in gora-ignite#297ndeneh93 wants to merge 4 commits intoapache:masterfrom
ndeneh93 wants to merge 4 commits intoapache:masterfrom
Conversation
The test assumed deterministic iteration order from Apache Ignite, causing nondeterministic assertion failures when the result keys were returned in different orders (e.g., [3,4,2] instead of [2,3,4]). This fix enforces deterministic ordering in the test before performing assertions, ensuring stability across repeated runs and NonDex executions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR
org.apache.gora.ignite.store.TestIgniteStore#testQueryKeyRangein thegora-ignitemodule.Why the test fails**
2L → 5Land asserts that the keys are[2, 3, 4].[3,4,2],[4,2,3], etc.How to reproduce the test failure**
mvn -pl gora-ignite test -Dtest=org.apache.gora.ignite.store.TestIgniteStore#testQueryKeyRange
mvn -pl gora-ignite edu.illinois:nondex-maven-plugin:2.1.1:nondex
-Dtest=org.apache.gora.ignite.store.TestIgniteStore#testQueryKeyRange
-DnondexRuns=30
Expected results**
Actual results**
Description of fix**
Review Questions & Answers