GOBBLIN-2263: Refresh DagAction latency anchor#4198
Open
agam-99 wants to merge 1 commit into
Open
Conversation
Stamp each submitted job with the current DagAction store insert time so the launch latency metric measures per-action queueing rather than elapsed DAG runtime. Also use UTF-8 binary collations for orchestration identifier tables so non-ASCII flow names can be compared safely. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
dagAction.launch.storeInsertTimeMillison each job'sJobSpecimmediately before executor submission, using the current DagAction lease timestamp instead of the original flow LAUNCH timestamp.LeaseParamsthrough launch, reevaluate, and resume DagProc submission paths so downstream jobs in multi-hop DAGs measure their own DagAction queueing latency rather than elapsed DAG runtime.GaaSJobObservabilityEventand GridGateway metric emission observe the same fresh anchor.dag_node_id/parent_dag_iduseutf8_binto stay within MySQL index limits.Tests
DagProcUtilsTest.testSubmitJobToExecutorReplacesStaleStoreInsertTimeMillisto verify stale anchors are replaced in bothJobSpecconfig and properties before submission.ReevaluateDagProcTest.testCurrentJobToRunReplacesStaleStoreInsertTimeMillisto cover the downstream REEVALUATE path.JAVA_HOME="/Library/Java/JavaVirtualMachines/jdk1.8.0_282-msft.jdk/Contents/Home" ./gradlew :gobblin-service:compileJava :gobblin-service:compileTestJavaJAVA_HOME="/Library/Java/JavaVirtualMachines/jdk1.8.0_282-msft.jdk/Contents/Home" ./gradlew :gobblin-service:test --tests "org.apache.gobblin.service.modules.orchestration.proc.DagProcUtilsTest"JAVA_HOME="/Library/Java/JavaVirtualMachines/jdk1.8.0_282-msft.jdk/Contents/Home" ./gradlew :gobblin-service:test --tests "org.apache.gobblin.service.modules.orchestration.proc.DagProcUtilsTest" --tests "org.apache.gobblin.service.modules.orchestration.proc.ReevaluateDagProcTest" --tests "org.apache.gobblin.service.modules.orchestration.proc.LaunchDagProcTest"; the suite compiled but failed duringTestMetastoreDatabaseFactorysetup because Docker/Testcontainers is not available in this environment.git diff --checkmint buildnot applicable: this checkout is not a LinkedIn multiproduct directory.Commits
Made with Cursor