[CORE] Add explicit tracking for disabled test suites#12512
Open
zml1206 wants to merge 4 commits into
Open
Conversation
|
Run Gluten Clickhouse CI on x86 |
zml1206
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit “disabled suite” concept to Gluten’s UT backend settings so suites can be intentionally marked as disabled (with a human-readable reason) instead of being silently omitted.
Changes:
- Introduces
disableSuite(...)and adisabledSuitesregistry inBackendTestSettings, and makesshouldRunshort-circuit disabled suites. - Updates Spark 4.0 / 4.1 Velox test settings to explicitly disable several suites with documented reasons.
- Adds Spark 4.0 / 4.1
GlutenSubExprEvaluationRuntimeSuitewrappers so the suite can be referenced and explicitly disabled.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| gluten-ut/common/src/test/scala/org/apache/gluten/utils/BackendTestSettings.scala | Adds disabled-suite tracking + API and integrates it into suite filtering. |
| gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Converts previously “not enabled” suites into explicitly disabled suites with reasons. |
| gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Same as Spark 4.0: explicitly disables suites with documented reasons. |
| gluten-ut/spark40/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenSubExprEvaluationRuntimeSuite.scala | Adds wrapper suite class so it can be explicitly disabled/tracked. |
| gluten-ut/spark41/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenSubExprEvaluationRuntimeSuite.scala | Same wrapper addition for Spark 4.1 (shim trait). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+53
to
+55
| protected def disableSuite(suiteName: String, reason: String): Unit = { | ||
| require(reason.nonEmpty, "Disable reason must not be empty") | ||
| if (enabledSuites.containsKey(suiteName)) { |
|
Run Gluten Clickhouse CI on x86 |
Comment on lines
37
to
+40
| protected def enableSuite(suiteName: String): SuiteSettings = { | ||
| if (disabledSuites.containsKey(suiteName)) { | ||
| throw new IllegalArgumentException("Suite is already disabled: " + suiteName) | ||
| } |
Comment on lines
+58
to
+60
| if (disabledSuites.containsKey(suiteName)) { | ||
| throw new IllegalArgumentException("Duplicated disabled suite: " + suiteName) | ||
| } |
Member
|
@zml1206, thank you for the PR. Can we remove https://github.com/search?q=repo%3Aapache%2Fgluten+.disable%28&type=code |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Comment on lines
+53
to
+57
| protected def disableSuite(suiteName: String, reason: String): Unit = { | ||
| require(reason.nonEmpty, "Disable reason must not be empty") | ||
| if (enabledSuites.containsKey(suiteName)) { | ||
| throw new IllegalArgumentException("Suite is already enabled: " + suiteName) | ||
| } |
|
Run Gluten Clickhouse CI on x86 |
Comment on lines
37
to
43
| protected def enableSuite(suiteName: String): SuiteSettings = { | ||
| if (disabledSuites.containsKey(suiteName)) { | ||
| throw new IllegalArgumentException("Suite is already disabled: " + suiteName) | ||
| } | ||
| if (enabledSuites.containsKey(suiteName)) { | ||
| throw new IllegalArgumentException("Duplicated suite name: " + suiteName) | ||
| } |
Comment on lines
+53
to
+62
| protected def disableSuite(suiteName: String, reason: String): Unit = { | ||
| require(reason.nonEmpty, "Disable reason must not be empty") | ||
| if (enabledSuites.containsKey(suiteName)) { | ||
| throw new IllegalArgumentException("Suite is already enabled: " + suiteName) | ||
| } | ||
| if (disabledSuites.containsKey(suiteName)) { | ||
| throw new IllegalArgumentException("Duplicated disabled suite: " + suiteName) | ||
| } | ||
| disabledSuites.put(suiteName, reason) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.