[VL] Support partial fallback generic unmapped catalyst expressions #12486
Open
taiyang-li wants to merge 6 commits into
Open
[VL] Support partial fallback generic unmapped catalyst expressions #12486taiyang-li wants to merge 6 commits into
taiyang-li wants to merge 6 commits into
Conversation
taiyang-li
changed the title
…l project Support custom catalyst expressions from user jars in ColumnarPartialProject when Velox cannot map them natively, while keeping ScalaUDF and HiveUDF on their existing fallback paths.
Keep the new generic unmapped catalyst expression note concise while preserving the intent of the fallback behavior.
taiyang-li
force-pushed
the
liyang/fallback-generic-unmapped-catalyst-expr
branch
from
e567ad0 to
6b98127
Compare
Contributor
|
Will this pr affect the CH backend? Can some UT be added to the CH backend? |
Contributor
Author
No. Only codes in velox backend modified. For Velox backend, I add 2 extra testGluten() uts and disable 2 original test() uts in spark4.0 and spark4.1. And it shouldn't have affect on CH backend. |
Contributor
Author
jackylee-ch
reviewed
Jul 15, 2026
|
|
||
| class GlutenVariantSuite extends VariantSuite with GlutenSQLTestsTrait {} | ||
| class GlutenVariantSuite extends VariantSuite with GlutenSQLTestsTrait { | ||
| testGluten("non-literal variant_get") { |
Contributor
There was a problem hiding this comment.
Since we won't test it in Spark 4.0, can we remote it?
Contributor
Author
There was a problem hiding this comment.
I saw `GlutenVariantSuite` was enabled in spark4.0 VeloxTestSettings.scala. Do I miss something?
| expr.deterministic && | ||
| !expr.isInstanceOf[Unevaluable] && | ||
| !expr.isInstanceOf[LambdaFunction] && | ||
| !ExpressionMappings.expressionsMap.contains(expr.getClass) |
Contributor
There was a problem hiding this comment.
do we need to consider the ExpressionConverter.tryTransformWithoutExpressionMapping whole check?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ColumnarPartialProject previously did not recognize generic unmapped catalyst expressions shipped in user jars. When such a custom catalyst expression was not registered in
ExpressionMappings, it was not identified for partial-project fallback and could still reach native expression conversion and fail at runtime.This patch makes Velox detect those generic unmapped catalyst expressions earlier and route them through
ColumnarPartialProjectfallback.ScalaUDFand Hive UDF keep using their existing dedicated paths instead of being folded into the generic fallback path.How was this patch tested?
DummyUnmappedExprinUDFPartialProjectSuiteDoes this PR introduce any user-facing change?
No.
Was this patch authored or co-authored using generative AI tooling?
Yes.
Generated-by: OpenAI GPT-5