[VL][FOLLOWUP] Reduce Velox hash shuffle partition buffer memory by evicting large partitions after split#12156
Open
wankunde wants to merge 1 commit into
Open
[VL][FOLLOWUP] Reduce Velox hash shuffle partition buffer memory by evicting large partitions after split#12156wankunde wants to merge 1 commit into
wankunde wants to merge 1 commit into
Conversation
…victing large partitions after split
marin-ma
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Bug fix for
VeloxHashShuffleWriter::doSplit.How does this issue happen :
splitState_ == kInit, doevictPartitionBuffers()to evict large partitions.evictPartitionBuffers(pid)calls assembleBuffers, which slices / copies / serializes buffers and may allocate from the Velox memory pool.reclaimFixedSize.evictState_is stillkEvictableandevictPartitionBuffersAfterSpill()is true, the arbitrator entersevictPartitionBuffersMinSize, which may select the same pid we are currently evicting.partitionBuffers_[*][pid],partitionBinaryAddrs_[*][pid], andpartitionBufferBase_[pid]while the outer call is still mid-assembly.How to fix this issue:
evictPartitionBuffers()before setsplitState_ == kInitHow was this patch tested?
Use exists UT
Was this patch authored or co-authored using generative AI tooling?
NO