[GLUTEN-11916][VL] Enable 7 Spark 4.1 TODO SQL query test files#12146
Open
rdtr wants to merge 1 commit into
Open
[GLUTEN-11916][VL] Enable 7 Spark 4.1 TODO SQL query test files#12146rdtr wants to merge 1 commit into
rdtr wants to merge 1 commit into
Conversation
Enable 7 of 11 TODO SQL query test files in spark41 VeloxSQLQueryTestSettings:
- cast.sql, describe.sql, literals.sql (+ nonansi imports): already passing
- nonansi/st-functions.sql: already passing
- type-coercion-edge-cases.sql: fix golden file for Spark 4.1 semi-structured
field access behavior change (col2.field on MAP now returns field extraction
instead of CAST_INVALID_INPUT error)
Remaining 4 TODOs triaged to separate issues:
- subquery/exists-subquery/exists-orderby-limit.sql: ANSI fallback + OFFSET
- scripting/randomly_generated_scripts.sql: NPE in condition handling
- st-functions.sql: geospatial types (new Spark 4.1, not in Velox)
- variant-field-extractions.sql: Variant type (apache#11371)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Summary
VeloxSQLQueryTestSettings([VL] Spark 4.1: Diagnose and enable TODO SQL query test files #11916)type-coercion-edge-cases.sql: Spark 4.1 changedMAPfield access behavior —col2.fieldonMAP<BIGINT, DOUBLE>now uses semi-structured field extraction (returnsstruct<field:double>) instead of attemptingCAST("field" AS BIGINT)which threwCAST_INVALID_INPUTin ANSI modeEnabled tests
Remaining 4 TODOs (triaged, not in this PR)
subquery/exists-subquery/exists-orderby-limit.sql-> ANSI fallback causesINTERNAL_ERRORon Spark 4.1OneRowRelationExecnull sessionscripting/randomly_generated_scripts.sql-> NPE in SQL scripting exception handler condition handlingst-functions.sql-> Geospatial types (GEOGRAPHY/GEOMETRY) new in Spark 4.1, not supported in Veloxvariant-field-extractions.sql-> Variant type not supported ([VL] Spark 4.x: Support Variant type #11371)I will check them too.
Test plan
GlutenSQLQueryTestSuitewithExtendedSQLTesttag)