[ISSUE-796] Clean up PartitionType TODOs in rocksdb store module - #823
Open
yyyCode wants to merge 1 commit into
Open
[ISSUE-796] Clean up PartitionType TODOs in rocksdb store module#823yyyCode wants to merge 1 commit into
yyyCode wants to merge 1 commit into
Conversation
The `PartitionType` enum in the rocksdb store carried two stale `TODO`s: - `// TODO: Support dt partition` on `DT` — DT partition is already implemented (`SyncGraphDtPartitionProxy`, dispatched by `ProxyBuilder`), so the TODO is removed. - `// TODO: Support label dt partition` on `DT_LABEL` — this combination has no proxy implementation. Configuring it previously fell through to a generic "unexpected partition type" error. `ProxyBuilder.build` now rejects `DT_LABEL` explicitly with a message that names the unsupported type, and the TODO is replaced with a NOTE documenting the gap. Adds `PartitionTypeTest` covering the enum lookup/flags, the explicit `DT_LABEL` rejection, and that `DT` is still dispatched to a real proxy. The test targets `ProxyBuilder` directly so it does not depend on opening a native RocksDB instance. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Closes #796.
Cleans up two stale
TODOs on thePartitionTypeenum in the rocksdb graph store (geaflow-store-rocksdb):DT—// TODO: Support dt partition: DT partition is already implemented viaSyncGraphDtPartitionProxyand dispatched byProxyBuilder, so this TODO is obsolete and is removed.DT_LABEL—// TODO: Support label dt partition: this combination has no proxy implementation. Previously, configuringpartition.type=dt_labelfell through to a generic"unexpected partition type"error.ProxyBuilder.buildnow rejectsDT_LABELexplicitly with a message that names the unsupported type (fail-fast), and the TODO is replaced with aNOTEdocumenting the gap for future implementers.No behavior change for the supported partition types (
NONE,LABEL,DT).How was this PR tested?
Added
PartitionTypeTestcovering:DT/DT_LABEL/NONE;ProxyBuilderrejectingDT_LABELwith an explicit message that names the type;ProxyBuilderstill dispatchingDTto a real proxy.The test targets
ProxyBuilderdirectly, so it does not require opening a native RocksDB instance.mvn test -Dtest=PartitionTypeTestpasses (5/5) andmvn checkstyle:checkreports 0 violations on the module.