test(cluster): avoid uncaught system exit exceptions - #821
Open
johntomcat7408-cmyk wants to merge 1 commit into
Open
test(cluster): avoid uncaught system exit exceptions#821johntomcat7408-cmyk wants to merge 1 commit into
johntomcat7408-cmyk wants to merge 1 commit into
Conversation
Author
|
The JDK 8 and JDK 11 workflows are waiting for approval. Could a maintainer approve them when convenient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SystemExitSignalCatcherinterceptedSystem.exit()by throwing an exception. The expected exception escaped the executor thread and appeared as an uncaught error in CI logs.This change makes the process exit action in
ComponentExceptionSupervisorreplaceable in tests. The cluster exception tests now capture and assert the exit code without installing aSecurityManager, andSystemExitSignalCatcheris removed. Production behavior is unchanged: the default action still callsSystem.exit(EXIT_CODE).Related to #701.
How was this PR tested?
Tests have Added for the changes
Production environment verified
JDK 11:
ContainerTestandComponentUncaughtExceptionHandlerTestOracle JDK 8u441 on CentOS 7: the same tests
Maven Checkstyle and Apache RAT for
geaflow-cluster