feat(xlang): add comprehensive read checks#3647
Merged
chaokunyang merged 10 commits intoapache:mainfrom May 6, 2026
Merged
Conversation
a091fec to
4e5ca49
Compare
pandalee99
approved these changes
May 5, 2026
pandalee99
approved these changes
May 5, 2026
0da491a to
cc07187
Compare
cc07187 to
4f93359
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Deserializers should reject malformed or attacker-controlled payloads before they can drive invalid protocol state or oversized allocations. This PR hardens root header, metadata, size, and string reads across the xlang runtimes and updates the specs to match the validated wire format.
What does this PR do?
Related issues
#1017
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
Benchmark
Not applicable; this PR adds deserialization validation and protocol tests rather than benchmark changes.