Skip to content

Conversation

@theweipeng
Copy link
Member

@theweipeng theweipeng commented Jan 19, 2026

Why?

What does this PR do?

  1. Add cross language test for JavaScript.
  2. Test cases in crossLanguage.test.ts are not completely implemented, The unimplemented parts will be merged in other PRS

Related issues

#3133

Does this PR introduce any user-facing change?

No, this PR don't change the APIs.

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

This PR only for cross lanauage tests, do not affect performance.


/** Executes cross-language tests against the Rust implementation. */
@Test
public class JavaScriptXlangTest extends XlangTestBase {
Copy link
Collaborator

@chaokunyang chaokunyang Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theweipeng You also need update .github/workflows/ci.yml to run JavaScriptXlangTest

Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theweipeng theweipeng merged commit f55826f into apache:main Jan 21, 2026
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants