[test] chore: fix flaky RemoteLogScannerITCase#3002
Open
fresh-borzoni wants to merge 1 commit intoapache:mainfrom
Open
[test] chore: fix flaky RemoteLogScannerITCase#3002fresh-borzoni wants to merge 1 commit intoapache:mainfrom
fresh-borzoni wants to merge 1 commit intoapache:mainfrom
Conversation
fresh-borzoni
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes flakiness in RemoteLogScannerITCase.testScanFromRemoteAndProject by making assertions order-insensitive when scanning projected rows from remote log segments (addressing #2992).
Changes:
- Collects scanned records into a list and asserts using
containsExactlyInAnyOrderElementsOffor projection[a, c]. - Applies the same order-insensitive assertion approach for reordered projection
[c, a]. - Adds explicit expected-row lists (
expectedRowsAC,expectedRowsCA) to validate both projections deterministically.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #2992
Collect records and assert with containsExactlyInAnyOrderElementsOf, same pattern used in testScanFromRemote