[common] Parse datatype from string in DataTypes. #2501
+900
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loserwang1024
force-pushed
the
parse-datatype
branch
2 times, most recently
from
18b92f3 to
4de9b51
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a string-to-DataType parser to simplify programmatic type definitions in Fluss. The implementation addresses issue #2500, which highlighted the complexity of creating nested row types using Java code by enabling users to parse types from strings instead.
Changes:
- Added
DataTypeParserclass with tokenization and parsing logic for converting string representations to DataType objects - Exposed
DataTypes.parse(String)as the public API entry point - Added comprehensive test suite covering various type parsing scenarios and error cases
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 19 comments.
| File | Description |
|---|---|
| fluss-common/src/main/java/org/apache/fluss/types/DataTypeParser.java | New parser implementation with tokenizer and recursive descent parser for DataType strings |
| fluss-common/src/main/java/org/apache/fluss/types/DataTypes.java | Added public parse() method that delegates to DataTypeParser |
| fluss-common/src/test/java/org/apache/fluss/types/DataTypeParserTests.java | Comprehensive test suite covering parsing, serialization round-trips, and error messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+56
to
+59
| TestSpec.forString("DEC(10, 3)").expectType(new DecimalType(10, 3)), | ||
| TestSpec.forString("NUMERIC(10, 3)").expectType(new DecimalType(10, 3)), | ||
| TestSpec.forString("TINYINT").expectType(new TinyIntType()), | ||
| TestSpec.forString("SMALLINT").expectType(new SmallIntType()), |
There was a problem hiding this comment.
This TODO comment suggests there's unfinished work regarding exception handling for "TIMESTAMP WITH TIME ZONE". Either implement the test case or document why this type is not supported and remove the TODO.
loserwang1024
force-pushed
the
parse-datatype
branch
from
4de9b51 to
9db8c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2500
Brief change log
Tests
API and Format
Documentation