-
Notifications
You must be signed in to change notification settings - Fork 528
[lake/tiering] Add per-table monitoring metrics for Lake Tiering #2454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e34e03e
[lake/tiering] Add per-table monitoring metrics for Lake Tiering
beryllw 58ff6ed
update stats reporting with nullable values and improved handling
beryllw 99c9f78
rm unused code
beryllw 39b6141
fix java8 ci
beryllw 4de3010
update tiering statistics handling with nullable support
beryllw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
fluss-common/src/main/java/org/apache/fluss/lake/committer/TieringStats.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.fluss.lake.committer; | ||
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| import java.io.Serializable; | ||
|
|
||
| /** | ||
| * Immutable statistics for a single completed tiering round of a lake table. | ||
| * | ||
| * <p>Fields use {@code null} to represent "unknown / not supported". | ||
| */ | ||
| public final class TieringStats implements Serializable { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| /** | ||
| * A {@code TieringStats} instance where every field is {@code null} (unknown/unsupported). Use | ||
| * this as the default when no stats are available. | ||
| */ | ||
| public static final TieringStats UNKNOWN = new TieringStats(null, null); | ||
|
|
||
| // ----------------------------------------------------------------------------------------- | ||
| // Lake data stats (reported by the lake committer) | ||
| // ----------------------------------------------------------------------------------------- | ||
|
|
||
| /** Cumulative total file size (bytes) of the lake table after this tiering round. */ | ||
| @Nullable private final Long fileSize; | ||
|
|
||
| /** Cumulative total record count of the lake table after this tiering round. */ | ||
| @Nullable private final Long recordCount; | ||
|
|
||
| public TieringStats(@Nullable Long fileSize, @Nullable Long recordCount) { | ||
| this.fileSize = fileSize; | ||
| this.recordCount = recordCount; | ||
| } | ||
|
|
||
| @Nullable | ||
| public Long getFileSize() { | ||
| return fileSize; | ||
| } | ||
|
|
||
| @Nullable | ||
| public Long getRecordCount() { | ||
| return recordCount; | ||
| } | ||
|
|
||
| /** | ||
| * Returns {@code true} when at least one stat field is non-{@code null}, meaning actual data | ||
| * was written during this tiering round. | ||
| */ | ||
| public boolean isAvailableStats() { | ||
| return fileSize != null || recordCount != null; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "TieringStats{" + "fileSize=" + fileSize + ", recordCount=" + recordCount + '}'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.