[c++] Add MAP/ROW types, unify complex types under Value handle#611
Open
fresh-borzoni wants to merge 3 commits into
Open
[c++] Add MAP/ROW types, unify complex types under Value handle#611fresh-borzoni wants to merge 3 commits into
fresh-borzoni wants to merge 3 commits into
Conversation
fresh-borzoni
force-pushed
the
feat/cpp-nested-map-row
branch
5 times, most recently
from
ca881ca to
c816666
Compare
Member
Author
leekeiabstraction
left a comment
leekeiabstraction
left a comment
Contributor
There was a problem hiding this comment.
TY for the PR. Reviewing this in parts; will continue the rest tomorrow. Left a clarification question.
leekeiabstraction
left a comment
leekeiabstraction
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the PR. Left some comments / questions.
fresh-borzoni
force-pushed
the
feat/cpp-nested-map-row
branch
from
c816666 to
d5bde42
Compare
Member
Author
|
@leekeiabstraction Thank you for the review, addressed, PTAL 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #604
closes #605
Adds MAP and ROW column support to the C++ client, bringing it in line with the Rust core and Python.
The substantive change is on the read side. ARRAY reads went through a per-type accessor family hung off each result type, and extending that to MAP and ROW would have meant a per-type cross-product across three result containers (scan, lookup, prefix lookup). Instead, any complex column is now read through a single recursive Value handle: navigate with At / KeyAt / ValueAt / Field, read leaves with the Get* methods. That replaced the old ArrayView/MapView/RowValue types everywhere and nests to any depth.
For schema and writes, you declare nested columns with DataType::Map / DataType::Row and build values with the existing writers - no Arrow in user code. Schema::FromArrow stays as an escape hatch for callers that already have an arrow::Schema, internally the native types are lowered to Arrow when the table is created.
The zero-copy scan path and the Arrow bulk path are left as-is.