[FLINK-40168][table] Thread the EARLY_FIRE hint into the interval join#28796
Draft
weiqingy wants to merge 6 commits into
Draft
[FLINK-40168][table] Thread the EARLY_FIRE hint into the interval join#28796weiqingy wants to merge 6 commits into
weiqingy wants to merge 6 commits into
Conversation
…dation Register the EARLY_FIRE join hint and its typed options (EarlyFireJoinHintOptions: delay, time_mode) with a key-value option checker, and wire the query-hint propagation touchpoints. Exclude EARLY_FIRE from the generic join-hint test coverage and config-docs generation, since it is a key-value hint validated on its own. The hint is recognized and validated here but not yet consumed by any rule; threading it into the interval join follows in a separate change.
…time-mode Flink option keys use hyphens (e.g. output-mode, fixed-delay); rename the EARLY_FIRE hint's time_mode option key to time-mode to match, and update the affected tests.
…idation tests The runtime uses delay.toMillis(), so a sub-millisecond delay truncates to zero. Make the contract explicit: require at least 1 millisecond in the DELAY description and the checker error message. Add coverage for a sub-millisecond delay, list-style options (only key-value is supported), and case-insensitive hint-name capitalization that preserves the key-value options.
…test class Move the EARLY_FIRE hint surface and option-validation tests out of the Scala IntervalJoinTest into a dedicated Java EarlyFireJoinHintTest (under plan/hints/stream, mirroring StateTtlHintTest), and relocate their plan golden accordingly. IntervalJoinTest keeps only its original tests.
Wrap the assertThatThrownBy chain in testEarlyFireListOptionsRejected to satisfy Spotless.
Collaborator
Contributor
Author
|
Hi @RocMarshal, opening PR-1b of the FLIP-497 stack ahead as a draft. It's stacked on #28353, so I'll rebase it onto master and take it out of draft for review once #28353 is merged. Thanks! |
weiqingy
force-pushed
the
FLINK-36953-pr1b-thread
branch
from
July 22, 2026 04:57
eed5d94 to
96ba48f
Compare
weiqingy
force-pushed
the
FLINK-36953-pr1b-thread
branch
from
July 22, 2026 05:10
96ba48f to
647116f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the FLIP-497 implementation stack under umbrella FLINK-36953. Landing order:
targetoptionWhat is the purpose of the change
Threads the (already-registered)
EARLY_FIREhint through the planner to the ExecNode.StreamPhysicalIntervalJoinRulereads the hint, resolves the effective time mode from the join's time domain, validates the domain combinations, and threads the delay and time mode intoStreamExecIntervalJoinas NON_NULL JSON fields. The operator receives the parameters but ignores them; runtime behavior lands in PR-4.Brief change log
StreamPhysicalIntervalJoinRulereads the hint, resolves the effective time mode, rejects row-time triggering on a processing-time join, and rejects (for now) processing-time triggering on an event-time join.earlyFireDelay/earlyFireTimeModethroughStreamPhysicalIntervalJoinintoStreamExecIntervalJoinas NON_NULL JSON fields.Verifying this change
This change added tests and can be verified as follows:
EarlyFireJoinHintTest:earlyFireDelay/earlyFireTimeModereach the exec plan for both a row-time (defaultROWTIME) and a processing-time (defaultPROCTIME) interval join; row-time-on-proctime and processing-time-on-rowtime are rejected; a compiled-plan JSON round-trip covers serialization of the new ExecNode fields.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Anthropic)