[FLINK-40214][table] Preserve JSON_OBJECTAGG key when wrapping value#28795
Open
Au-Miner wants to merge 1 commit into
Open
[FLINK-40214][table] Preserve JSON_OBJECTAGG key when wrapping value#28795Au-Miner wants to merge 1 commit into
Au-Miner wants to merge 1 commit into
Conversation
Collaborator
Contributor
Author
|
@xuyangzhong, could you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes incorrect
JSON_OBJECTAGGresults when the key and value reference the same input field. Previously, object keys could contain additional escaped quotation marks.Brief change log
WrapJsonAggFunctionArgumentsRule#wrapJsonAggregateto replace only the value argument with its wrapped projection while preserving the originalJSON_OBJECTAGGkey argument.Verifying this change
JsonAggregationFunctionsITCaseadds regression coverage for regular and tumbling-window aggregations where the key and value use the same field.The expected result is:
{"A":"A","B":"B"}The
WrapJsonAggFunctionArgumentsRuleTestplan snapshots verify that only the value argument references theJSON_STRINGprojection.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation