FLINK-XXXXX: add GROUP BY <int literal>, GROUP BY ALL, ORDER BY ALL support#28330
Draft
tisyabhatia wants to merge 2 commits into
Draft
FLINK-XXXXX: add GROUP BY <int literal>, GROUP BY ALL, ORDER BY ALL support#28330tisyabhatia wants to merge 2 commits into
tisyabhatia wants to merge 2 commits into
Conversation
Collaborator
raminqaf
reviewed
Jun 5, 2026
snuyanzin
reviewed
Jun 5, 2026
Comment on lines
+2600
to
+2601
| SqlParserPos pos; | ||
| List<SqlNode> res; |
Contributor
There was a problem hiding this comment.
what is the reason of this change?
We should not touch this file
we should only put here backports from Calcite and nothing more
snuyanzin
requested changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request adds initial support for
GROUP BY ALLin Flink SQL.The change introduces parser and validator support for
GROUP BY ALL, adds planner handling behind a configuration flag, and includes parser and batch planner test coverage. The implementation is intentionally scoped and does not attempt to support all related variants yet.This work is also backed by an internal design doc and FLIP draft.
Brief change log
GROUP BY ALLSqlGroupByAllOperatorrepresentation for parsing and validationGROUP BY ALLGROUP BY ALLGROUP BY ALLVerifying this change
This change added tests and can be verified as follows:
FlinkSqlParserImplTestGroupByAllTestGROUP BY ALLDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Glean