[FLINK-36973][config] Skip options not explicitly set when converting SavepointRestoreSettings to Configuration#28295
Open
AlexYinHan wants to merge 1 commit into
Open
[FLINK-36973][config] Skip options not explicitly set when converting SavepointRestoreSettings to Configuration#28295AlexYinHan wants to merge 1 commit into
AlexYinHan wants to merge 1 commit into
Conversation
Collaborator
… SavepointRestoreSettings to Configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes the issue in FLINK-39673. It skips writing
RESTORE_MODEandSAVEPOINT_IGNORE_UNCLAIMED_STATEfromSavepointRestoreSettingsintoConfigurationwhen they were not explicitly provided. If the user uses deprecated configuration keys for these options, this prevents the configurations from being overridden by default values.Brief change log
SavepointRestoreSettings, change theallowNonRestoredStateandrecoveryClaimModefromNonNulltoNullable, to tell whether they are explicitly provided.SavepointRestoreSettings.toConfiguration()to skip writingRESTORE_MODEandSAVEPOINT_IGNORE_UNCLAIMED_STATEwhen they were not explicitly provided by the user.Verifying this change
This change added tests and can be verified as follows:
SavepointRestoreSettingsTest.javaAdded test that validates that default/null values of SavepointRestoreSettings are correctly handledDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: [Claude-4.6-Opus]