Skip to content

[FLINK-36267][table] Fix SPLIT not preserving SMP characters when delimiter is empty#28264

Open
Au-Miner wants to merge 1 commit into
apache:masterfrom
Au-Miner:FLINK-36267
Open

[FLINK-36267][table] Fix SPLIT not preserving SMP characters when delimiter is empty#28264
Au-Miner wants to merge 1 commit into
apache:masterfrom
Au-Miner:FLINK-36267

Conversation

@Au-Miner
Copy link
Copy Markdown
Contributor

What is the purpose of the change

Fix the SQL SPLIT function so that, when called with an empty delimiter, it preserves Supplementary Multilingual Plane characters (e.g. emoji) as single elements instead of breaking surrogate pairs into invalid "?" placeholders.

Brief change log

  • Change the empty-delimiter branch in SplitFunction#eval to iterate by Unicode code points (codePointAt + Character.charCount) instead of by UTF-16 code units, so surrogate-pair characters are emitted as one element.

Verifying this change

Added a new test case in CollectionFunctionsITCase#splitTestCases that asserts SPLIT('123😊笑脸', '') returns ["1", "2", "3", "😊", "笑", "脸"], covering the SMP character path across both Table API and SQL.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 27, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@raminqaf raminqaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution! Left some nit comments!

"12345",
",123,,,123,")
",123,,,123,",
"123😊笑脸")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just harden the test with two SMP chars?

Suggested change
"123😊笑脸")
"123😊👍🏽笑脸")

Comment on lines +53 to 58
while (i < str.length()) {
int codePoint = str.codePointAt(i);
int charCount = Character.charCount(codePoint);
res.add(StringData.fromString(str.substring(i, i + charCount)));
i += charCount;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this reads better

Suggested change
while (i < str.length()) {
int codePoint = str.codePointAt(i);
int charCount = Character.charCount(codePoint);
res.add(StringData.fromString(str.substring(i, i + charCount)));
i += charCount;
}
while (i < str.length()) {
int codePoint = str.codePointAt(i);
int nextIndex = i + Character.charCount(codePoint);
res.add(StringData.fromString(str.substring(i, nextIndex)));
i = nextIndex;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants