[BP-2.2][FLINK-39242][python] Fix error when getting columns from ResolvedSchema#27761
Open
autophagy wants to merge 1 commit intoapache:release-2.2from
Open
[BP-2.2][FLINK-39242][python] Fix error when getting columns from ResolvedSchema#27761autophagy wants to merge 1 commit intoapache:release-2.2from
autophagy wants to merge 1 commit intoapache:release-2.2from
Conversation
Collaborator
davidradl
reviewed
Mar 12, 2026
| self.assertEqual(resolved_schema, expected_schema) | ||
|
|
||
| def test_resolved_schema_get_columns(self): | ||
| physical_schema = ResolvedSchema.physical( |
Contributor
There was a problem hiding this comment.
I realise this is a port - but it worth be worth testing the computed and metadata cases as well I think. Unelss they are already covered.
Contributor
Author
There was a problem hiding this comment.
Good point - i'll open a follow up PR against master for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of 74a3243.