[FLINK-23555] Support common sub-expression elimination in code generation#27750
Open
featzhang wants to merge 2 commits intoapache:masterfrom
Open
[FLINK-23555] Support common sub-expression elimination in code generation#27750featzhang wants to merge 2 commits intoapache:masterfrom
featzhang wants to merge 2 commits intoapache:masterfrom
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented CSE optimization for Flink SQL code generation. Key changes:
New files:
CseUtils.scala- Utility to scan RexNode trees and identify duplicate sub-expressionsCseITCase.scala- Integration tests for CSE (correctness, call count, null handling, nested)CseTestFunctions.java- Test UDFs with AtomicInteger call countersCseUtilsTest.scala- Unit tests for the CSE analyzerModified files:
ExprCodeGenerator.scala- AddedcseEnabled,cseExprCache,cseCandidatesfields and CSE logic ingenerateExpression(). Also changed operand visiting invisitCallto go throughgenerateExpression(notaccept(this)) so nested sub-expressions are also cached.CalcCodeGenerator.scala- Added CSE analysis before projection code generation usingCseUtils.findDuplicateSubExpressions()Approach: RexNode digest string is used as expression identity key. Only RexCall nodes appearing more than once are cached. First encounter generates code + stores in local variable. Subsequent encounters return NO_CODE reference to cached variable.
Test results (all passing):
CseJavaITCase: 5/5 ✅ (testCseCorrectness, testCseCallCount, testNoCseCandidates, testCseWithNullValues, testCseWithNestedCommonSubExpressions)CseUtilsTest: 6/6 ✅