[FLINK-38967] Fix flaky UnalignedCheckpointFailureHandlingITCase#27466
Merged
ferenc-csaky merged 2 commits intoapache:masterfrom Jan 28, 2026
Merged
[FLINK-38967] Fix flaky UnalignedCheckpointFailureHandlingITCase#27466ferenc-csaky merged 2 commits intoapache:masterfrom
ferenc-csaky merged 2 commits intoapache:masterfrom
Conversation
Collaborator
davidradl
reviewed
Jan 23, 2026
| } | ||
| } | ||
| } | ||
| } while (!foundCheckpointFailure || failOnCloseRef.get().get()); |
Contributor
There was a problem hiding this comment.
without the sleep isn't this now a tight loop until it completes?
Contributor
Author
There was a problem hiding this comment.
I think it's not that bad, as there is also a call to trigger the checkpoint that also waits for the result
github-actions
Bot
added
the
community-reviewed
liuml07
approved these changes
Jan 23, 2026
| if (cpFailure.isPresent()) { | ||
| if (isCausedBy(cpFailure.get(), expectedException)) { | ||
| foundCheckpointFailure = true; | ||
| } |
Member
There was a problem hiding this comment.
If it's not caused by expected exception, shall we still rethrow to ail fast with actual error ?
Contributor
Author
There was a problem hiding this comment.
Good idea, thank you, added that.
| } | ||
| } | ||
| } | ||
| } while (!foundCheckpointFailure || failOnCloseRef.get().get()); |
ferenc-csaky
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
UnalignedCheckpointFailureHandlingITCasefails intermittently as a race condition was not properly handled in the test code.Brief change log
failOnCloseRefto make sure that the channel state writer had the opportunity to call thecloseAndGetHandleandclosemethods.Verifying this change
Could not reproduce the test failure anymore
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation