[FLINK-38964][table] Reuse Calcite's SqlValidatorImpl#maybeCast
#27461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
commented
Jan 22, 2026
| } | ||
|
|
||
| private SqlNode maybeCast(SqlNode node, RelDataType currentType, RelDataType desiredType) { | ||
| protected SqlNode maybeCast(SqlNode node, RelDataType currentType, RelDataType desiredType) { |
Contributor
Author
There was a problem hiding this comment.
this change has already been committed to Calcite and will come with future updates
apache/calcite@f6271b7
snuyanzin
changed the title
SlqValidatorImpl#maybeCastSqlValidatorImpl#maybeCast
Collaborator
snuyanzin
commented
Jan 23, 2026
Comment on lines
-83
to
-84
| // This code snippet is copied from the SqlValidatorImpl. | ||
| def maybeCast( |
Contributor
Author
There was a problem hiding this comment.
instead of having old copy reuse the actual version of that method
github-actions
bot
added
the
community-reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This method was introduced in FLINK-26460 (Calcite 1.26)
Since then we bumped Calcite 10 versions up (now it is 1.36)
the problem is fixed in Calcite
Verifying this change
Existing tests added within FLINK-26460
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation