Skip to content

FINERACT-2165: Migrate SavingsAccountChargeRoundingTest to Feign - #6306

Open
Dhanno98 wants to merge 1 commit into
apache:developfrom
Dhanno98:FINERACT-2165/migrate-savings-account-charge-rounding
Open

FINERACT-2165: Migrate SavingsAccountChargeRoundingTest to Feign#6306
Dhanno98 wants to merge 1 commit into
apache:developfrom
Dhanno98:FINERACT-2165/migrate-savings-account-charge-rounding

Conversation

@Dhanno98

@Dhanno98 Dhanno98 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Description

Part of FINERACT-2165 system-wide migration of integration tests to fineract-client-feign.

Migrates SavingsAccountChargeRoundingTest from the legacy Fineract client to the Fineract Feign Client.

The migration:

  • Updates savings product and savings account setup to use the Feign test helpers.
  • Migrates savings account charge creation, application, and retrieval to the Feign client.
  • Migrates savings account deposits, withdrawals, and account retrieval to the Feign client.
  • Adds the required savings charge and business-date helpers to the Feign savings test infrastructure.
  • Preserves the existing test scenarios and assertions without changing their intended behavior.

All existing SavingsAccountChargeRoundingTest scenarios pass after the migration.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant