FINERACT-2763: Checker Users Unable to Approve Pending Maker-Checker Tasks Without Direct Operational Permissions and Missing Tasks in Checker Inbox - #6284
Open
rymghosn wants to merge 2 commits into
Conversation
rymghosn
added a commit
to foodeveloper/cbs-fineract
that referenced
this pull request
Aug 18, 2026
OffsetDateTime.now() without an explicit zone fails the JavaTimeDefaultTimeZone errorprone check, as flagged by CI on PR apache#6284.
…oan, and savings account GET responses
Currently, when a client, loan, or savings account has one or more maker-checker
actions awaiting checker approval, there is no way to discover this from the
corresponding GET API response. A caller has to separately query the
checker inbox/pending-audit endpoints and correlate entries by entity, which
is easy to miss and leaves API consumers unaware that the record they just
fetched has a pending change awaiting approval.
This adds a pendingMakerCheckerApprovals field to the ClientData,
LoanAccountData, SavingsAccountData, and DepositAccountData (fixed/recurring
deposit) response objects. When a GET request for one of these entities is
served, the field is populated with any CommandSource entries still
AWAITING_APPROVAL for that entity (id, action name, entity name, permission
code, maker username, and submission date), or omitted (null) when there is
nothing pending.
Changes:
- New PendingMakerCheckerData DTO and MakerCheckerReadService/
MakerCheckerReadServiceImpl to look up pending CommandSource rows by
loan/client/savings id.
- New CommandSourceRepository.findPendingBy{Loan,Client,Savings}Id queries
(join fetch c.maker to avoid N+1 lookups for the maker username).
- Wired into ClientReadPlatformServiceImpl#retrieveOne,
LoanReadPlatformServiceImpl#retrieveOne,
SavingsAccountReadPlatformServiceImpl#retrieveOne, and
DepositAccountReadPlatformServiceImpl#retrieveOne.
This is a read-only, additive change - it does not alter maker-checker
approval/permission logic itself, only exposes existing pending-approval
state that was previously only visible via the checker inbox.
OffsetDateTime.now() without an explicit zone in the test fails the
JavaTimeDefaultTimeZone errorprone check; uses OffsetDateTime.now(ZoneOffset.UTC)
instead.
rymghosn
force-pushed
the
port/CBS-539-pending-maker-checker-status-in-get-response
branch
from
August 18, 2026 14:05
d569fa3 to
5109f9d
Compare
CI's spotlessJavaCheck flagged wrapping/line-length violations in the new MakerCheckerReadServiceImpl and its test; ran spotlessApply to bring them in line with the project's palantir-java-format config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a client, loan, or savings account has one or more maker-checker actions awaiting checker approval, there is no way to discover this from the corresponding GET API response. A caller has to separately query the checker inbox/pending-audit endpoints and correlate entries by entity, which is easy to miss and leaves API consumers unaware that the record they just fetched has a pending change awaiting approval.
This PR adds a pendingMakerCheckerApprovals field to the ClientData, LoanAccountData, SavingsAccountData, and DepositAccountData (fixed/recurring deposit) response objects. When a GET request for one of these entities is served, the field is populated with any CommandSource entries still AWAITING_APPROVAL for that entity (id, action name, entity name, permission code, maker username, and submission date), or omitted (null) when there is nothing pending.
Changes:
loan/client/savings id.
SavingsAccountReadPlatformServiceImpl#retrieveOne, and DepositAccountReadPlatformServiceImpl#retrieveOne.
This is a read-only, additive change — it does not alter maker-checker approval/permission logic itself, only exposes existing pending-approval
state that was previously only visible via the checker inbox.
PR:(https://issues.apache.org/jira/browse/FINERACT-2763)