Skip to content

FINERACT-9: Repayment-Transactions-allocated-to-FINANCIAL_ACTIVITY.LIABILITY_TRANSFER#5881

Open
a7med3del1973 wants to merge 1 commit into
apache:developfrom
a7med3del1973:FINERACT-9/Repayment-Transactions-allocated-to-FINANCIAL_ACTIVITY.LIABILITY_TRANSFER
Open

FINERACT-9: Repayment-Transactions-allocated-to-FINANCIAL_ACTIVITY.LIABILITY_TRANSFER#5881
a7med3del1973 wants to merge 1 commit into
apache:developfrom
a7med3del1973:FINERACT-9/Repayment-Transactions-allocated-to-FINANCIAL_ACTIVITY.LIABILITY_TRANSFER

Conversation

@a7med3del1973
Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Copilot AI review requested due to automatic review settings May 23, 2026 05:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR adjusts how isAccountTransfer is handled when building SavingsTransactionDTO, introducing a local variable (localIsAccountTransfer) instead of mutating the existing isAccountTransfer variable.

Changes:

  • Introduced a local boolean (localIsAccountTransfer) to hold per-transaction account-transfer evaluation.
  • Updated SavingsTransactionDTO construction to use localIsAccountTransfer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants