Skip to content

FINERACT-2511: Return 400 for invalid dateFormat on client create/update#5641

Open
oluexpert99 wants to merge 1 commit intoapache:developfrom
TECHSERVICES-LIMITED:bugfix/FINERACT-2511
Open

FINERACT-2511: Return 400 for invalid dateFormat on client create/update#5641
oluexpert99 wants to merge 1 commit intoapache:developfrom
TECHSERVICES-LIMITED:bugfix/FINERACT-2511

Conversation

@oluexpert99
Copy link
Contributor

  • Validate dateFormat in ClientDataValidator (create and update) so invalid patterns (e.g. "02 February 2026") are rejected with 400 instead of 500.
  • Add @DateFormat constraint and DateFormatValidator in fineract-validation; ClientDataValidator uses DateFormatValidator.isValidPattern() for reuse.
  • Annotate BusinessDateUpdateRequest.dateFormat with @DateFormat.
  • Add ClientDataValidatorTest and DateFormatValidationTest.

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

  - Validate dateFormat in ClientDataValidator (create and update) so invalid
    patterns (e.g. "02 February 2026") are rejected with 400 instead of 500.
  - Add @DateFormat constraint and DateFormatValidator in fineract-validation;
    ClientDataValidator uses DateFormatValidator.isValidPattern() for reuse.
  - Annotate BusinessDateUpdateRequest.dateFormat with @DateFormat.
  - Add ClientDataValidatorTest and DateFormatValidationTest.

Signed-off-by: oluexpert99 <farooq@techservicehub.io>
@oluexpert99
Copy link
Contributor Author

@adamsaghy , This is a cleaner version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant