FINERACT-1474: Remove hard-coded constants from ExternalCreditBureauTest#5636
Open
debcodes076 wants to merge 1 commit intoapache:developfrom
Open
FINERACT-1474: Remove hard-coded constants from ExternalCreditBureauTest#5636debcodes076 wants to merge 1 commit intoapache:developfrom
debcodes076 wants to merge 1 commit intoapache:developfrom
Conversation
55b4100 to
6414dbe
Compare
IOhacker
requested changes
Mar 16, 2026
Contributor
IOhacker
left a comment
There was a problem hiding this comment.
Hello, "ThitsaWorks" seems to be non neutral, it must be removed or replaced.
6414dbe to
ea97caa
Compare
ea97caa to
961609c
Compare
Author
thank you for the feedback! i've refactored the code to replace all "Thitsaworks.." references with "ExternalCredit..." (including file name, classnames, method names) to ensure vendor neutrality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Issue 1474 by refactoring the ExternalCreditBureauIntegrationWritePlatformServiceImplTest.java file and its implementation to remove hard-coded strings and magic numbers.
Changes Made
private static finalconstants forCREDIT_BUREAU_ID,TEST_USERNAME,TEST_PASSWORD, andTEST_URL.setup()method and all@Testcases to utilize these constants.Verification
./gradlew :fineract-provider:test --tests "org.apache.fineract.infrastructure.creditbureau.service.ExternalCreditBureauIntegrationWritePlatformServiceImplTest"Checklist
This is my first contribution to Apache Fineract as part of my GSoC 2026 preparation.