FINERACT-2537: Add unit tests for StreamResponseUtil#5627
Open
devi-pathak2263 wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2537: Add unit tests for StreamResponseUtil#5627devi-pathak2263 wants to merge 1 commit intoapache:developfrom
devi-pathak2263 wants to merge 1 commit intoapache:developfrom
Conversation
c8a58b9 to
327f5e5
Compare
Contributor
|
@devi-pathak2263 Can you please: Set the commit email address to match with your github account email address? |
Tests cover: - ok(StreamResponseData) response creation - ok(AsyncResponse, StreamResponseData) asynchronous response handling - Content-Disposition header generation - StreamingOutput functionality - Async response execution These tests improve test coverage and help ensure correct behavior of response streaming utilities.
327f5e5 to
34d4689
Compare
Author
I have updated the commit author email to match my GitHub account and amended the commit with a GPG signature. I also updated the test imports to follow project conventions. Please let me know if anything else needs adjustment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests for the
StreamResponseUtilutility class infineract-core.The following functionality is covered:
ok(StreamResponseData)response generationok(AsyncResponse, StreamResponseData)asynchronous response handlingdispositionTypeis emptydispositionTypeis present (attachment/inline)Content-DispositionheadersStreamingOutputcorrectly writes the provided stream contentThese tests improve code coverage and help ensure correct behavior of response streaming utilities used in the project.
JIRA: https://issues.apache.org/jira/browse/FINERACT-2537
Testing
Executed locally:
./gradlew spotlessApply
./gradlew :fineract-core:test
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!