Skip to content

FINERACT-2530: Fix 500 error on GET /provisioningentries/{id} when no loan products exist#5621

Open
shubhamkumar9199 wants to merge 1 commit intoapache:developfrom
shubhamkumar9199:fix/FINERACT-2530-provisioning-empty-result
Open

FINERACT-2530: Fix 500 error on GET /provisioningentries/{id} when no loan products exist#5621
shubhamkumar9199 wants to merge 1 commit intoapache:developfrom
shubhamkumar9199:fix/FINERACT-2530-provisioning-empty-result

Conversation

@shubhamkumar9199
Copy link

@shubhamkumar9199 shubhamkumar9199 commented Mar 14, 2026

Change INNER JOIN to LEFT JOIN in PROVISIONING_ENTRY_SUM_RESERVED_SCHEMA so that provisioning entries with no associated loan product rows still return a valid result instead of throwing EmptyResultDataAccessException.

FINERACT-2530

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@shubhamkumar9199 shubhamkumar9199 changed the title FINERACT-2530: Fix 500 error on GET /provisioningentries/{id} when no… FINERACT-2530: Fix 500 error on GET /provisioningentries/{id} when no loan products exist Mar 14, 2026
@shubhamkumar9199 shubhamkumar9199 force-pushed the fix/FINERACT-2530-provisioning-empty-result branch 2 times, most recently from 97d0a0e to 7a2c453 Compare March 14, 2026 18:20
Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy
Copy link
Contributor

/home/runner/work/fineract/fineract/integration-tests/src/test/java/org/apache/fineract/integrationtests/common/ProvisioningIntegrationTest.java:39: error: cannot find symbol
import org.apache.fineract.client.models.PostProvisioningEntriesRequest;
                                        ^
  symbol:   class PostProvisioningEntriesRequest
  location: package org.apache.fineract.client.models

@shubhamkumar9199 shubhamkumar9199 force-pushed the fix/FINERACT-2530-provisioning-empty-result branch 2 times, most recently from 29b984d to 0d54925 Compare March 17, 2026 01:22
@shubhamkumar9199 shubhamkumar9199 force-pushed the fix/FINERACT-2530-provisioning-empty-result branch from 0d54925 to eee4d79 Compare March 17, 2026 05:59
@adamsaghy
Copy link
Contributor

@shubhamkumar9199 Please review the failing checks.
Let me know if you need a helping hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants