FINERACT-2530: Fix 500 error on GET /provisioningentries/{id} when no loan products exist#5621
Open
shubhamkumar9199 wants to merge 1 commit intoapache:developfrom
Conversation
97d0a0e to
7a2c453
Compare
Contributor
|
29b984d to
0d54925
Compare
… loan products exist
0d54925 to
eee4d79
Compare
Contributor
|
@shubhamkumar9199 Please review the failing checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change INNER JOIN to LEFT JOIN in PROVISIONING_ENTRY_SUM_RESERVED_SCHEMA so that provisioning entries with no associated loan product rows still return a valid result instead of throwing EmptyResultDataAccessException.
FINERACT-2530
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.