Skip to content

FINERACT-2494: Standardize operationId for Savings module and sync in…#5615

Open
Ambika-Sony wants to merge 1 commit intoapache:developfrom
Ambika-Sony:FINERACT-2494-standardization-clean
Open

FINERACT-2494: Standardize operationId for Savings module and sync in…#5615
Ambika-Sony wants to merge 1 commit intoapache:developfrom
Ambika-Sony:FINERACT-2494-standardization-clean

Conversation

@Ambika-Sony
Copy link
Contributor

@Ambika-Sony Ambika-Sony commented Mar 12, 2026

Description
This PR standardizes the operationId naming convention for the Savings module following the pattern methodName + Entity.

Key Updates:

Standardization: Updated SavingsAccountsApiResource operationIds to align with the project-wide naming convention.

Sync & Integration: Synchronized the branch with the latest FINERACT-2501 architecture and resolved complex merge conflicts in SavingsAccountsExternalIdTest.

Refactor Alignment: Integrated the recent Fineract 1.15.0-SNAPSHOT module reorganization to ensure compatibility with the current develop branch.

Checkstyle: Resolved lexicographical import order violations in API resources.

Checklist
[x] Standardized SavingsAccountsApiResource operationIds.

[x] Updated SavingsAccountsExternalIdTest to match new client method names.

[x] Resolved merge conflicts and synchronized with FINERACT-2501-collab.

[x] Verified build locally with ./gradlew :fineract-provider:checkstyleMain

@adamsaghy
Copy link
Contributor

@Ambika-Sony Please check the failing checks!

@adamsaghy
Copy link
Contributor

duplicate with #5597 ?

@adamsaghy
Copy link
Contributor

* What went wrong:
Execution failed for task ':fineract-provider:checkstyleMain'.
> A failure occurred while executing org.gradle.api.plugins.quality.internal.CheckstyleAction

[Incubating] Problems report is available at: file:///home/runner/work/fineract/fineract/build/reports/problems/problems-report.html
   > Checkstyle rule violations were found. See the report at: file:///home/runner/work/fineract/fineract/fineract-provider/build/reports/checkstyle/main.html
     Checkstyle files with violations: 1
     Checkstyle violations by severity: [error:1]


  * What went wrong:
  Execution failed for task ':integration-tests:compileTestJava'.
  > Compilation failed; see the compiler output below.
    warning: No processor claimed any of these annotations: /org.junit.jupiter.api.extension.ExtendWith,/org.apache.fineract.integrationtests.CIOnly,/feign.QueryMap,/org.mapstruct.Mapper,/jakarta.validation.constraints.NotNull,/org.junit.jupiter.api.DisplayName,/org.mapstruct.Mappings,/org.junit.jupiter.api.BeforeEach,/org.junit.jupiter.params.provider.ValueSource,/org.junit.jupiter.api.TestMethodOrder,/org.junit.jupiter.api.Order,/org.junit.jupiter.api.AfterEach,/org.mockserver.junit.jupiter.MockServerSettings,/retrofit2.http.Path,/edu.umd.cs.findbugs.annotations.SuppressFBWarnings,/org.junit.jupiter.params.provider.MethodSource,/org.junit.jupiter.api.extension.RegisterExtension,/feign.Headers,/org.junit.jupiter.api.AfterAll,/retrofit2.http.Headers,/org.junit.jupiter.api.Nested,/org.mockito.Mock,/org.mockito.InjectMocks,/retrofit2.http.Query,/org.junit.jupiter.api.TestInstance,/org.springframework.lang.Nullable,/feign.RequestLine,/org.junit.jupiter.api.Test,/org.junit.jupiter.api.BeforeAll,/org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable,/org.junit.jupiter.params.provider.CsvSource,/org.apache.fineract.integrationtests.support.instancemode.ConfigureInstanceMode,/org.springframework.lang.NonNull,/org.junit.jupiter.params.ParameterizedTest,/org.junit.jupiter.api.Disabled,/retrofit2.http.GET
    25 errors
    1,500 warnings

@Ambika-Sony
Copy link
Contributor Author

duplicate with #5597 ?

Hi @adamsaghy, thank you for the feedback. I realize my work on the Loan module standardization overlaps with Edward's PR #5597. To avoid further duplication and build conflicts, I am going to:

Close this PR (or revert the duplicate API changes).

Sync my local branch with Edward’s #5597 changes.

Focus on fixing the failing Integration Tests in fineract-client to ensure the new operationIds are correctly implemented.

Fix the Checkstyle error in my remaining work.

I'll update the PR once the tests are passing against the new standardized API.

@Ambika-Sony Ambika-Sony force-pushed the FINERACT-2494-standardization-clean branch from 6c04315 to 1bd3401 Compare March 17, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants