FINERACT-2494: Standardize operationId for Savings module and sync in…#5615
Open
Ambika-Sony wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2494: Standardize operationId for Savings module and sync in…#5615Ambika-Sony wants to merge 1 commit intoapache:developfrom
Ambika-Sony wants to merge 1 commit intoapache:developfrom
Conversation
6 tasks
Contributor
|
@Ambika-Sony Please check the failing checks! |
Contributor
|
duplicate with #5597 ? |
Contributor
|
Contributor
Author
Hi @adamsaghy, thank you for the feedback. I realize my work on the Loan module standardization overlaps with Edward's PR #5597. To avoid further duplication and build conflicts, I am going to: Close this PR (or revert the duplicate API changes). Sync my local branch with Edward’s #5597 changes. Focus on fixing the failing Integration Tests in fineract-client to ensure the new operationIds are correctly implemented. Fix the Checkstyle error in my remaining work. I'll update the PR once the tests are passing against the new standardized API. |
… Checkstyle violations
6c04315 to
1bd3401
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR standardizes the operationId naming convention for the Savings module following the pattern methodName + Entity.
Key Updates:
Standardization: Updated SavingsAccountsApiResource operationIds to align with the project-wide naming convention.
Sync & Integration: Synchronized the branch with the latest FINERACT-2501 architecture and resolved complex merge conflicts in SavingsAccountsExternalIdTest.
Refactor Alignment: Integrated the recent Fineract 1.15.0-SNAPSHOT module reorganization to ensure compatibility with the current develop branch.
Checkstyle: Resolved lexicographical import order violations in API resources.
Checklist
[x] Standardized SavingsAccountsApiResource operationIds.
[x] Updated SavingsAccountsExternalIdTest to match new client method names.
[x] Resolved merge conflicts and synchronized with FINERACT-2501-collab.
[x] Verified build locally with ./gradlew :fineract-provider:checkstyleMain