FINERACT-2455: Working Capital - Delinquency Management - Configuration#5612
Draft
somasorosdpc wants to merge 2 commits intoapache:developfrom
Draft
FINERACT-2455: Working Capital - Delinquency Management - Configuration#5612somasorosdpc wants to merge 2 commits intoapache:developfrom
somasorosdpc wants to merge 2 commits intoapache:developfrom
Conversation
budaidev
reviewed
Mar 11, 2026
| * under the License. | ||
| */ | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
duplicated license on the top (had the same issue before with spotless for some reason)
| @Converter(autoApply = true) | ||
| public class BucketTypeConverter implements AttributeConverter<BucketType, Long> { | ||
| @Override | ||
| public Long convertToDatabaseColumn(BucketType minimumPayment) { |
Contributor
There was a problem hiding this comment.
lets use bucketType variable name for consistency
| return dataValidator.hasError() ? null : new DelinquencyBucketData(null, name, ranges); | ||
|
|
||
| final Long bucketTypeParam = jsonHelper.extractLongNamed(DelinquencyApiConstants.BUCKET_TYPE_PARAM_NAME, element); | ||
| dataValidator.reset().parameter(DelinquencyApiConstants.BUCKET_TYPE_PARAM_NAME).value(rangeIds) |
Contributor
There was a problem hiding this comment.
isn't this bucketTypeParam instead of rangeIds?
| @NoArgsConstructor | ||
| @Entity | ||
| @Table(name = "m_delinquency_payment_rule") | ||
| public class DelinquencyMinimumPaymentPeriodAndRule extends AbstractAuditableWithUTCDateTimeCustom<Long> { |
Contributor
There was a problem hiding this comment.
I see we store the following values: frequency, frequency type, minimum payment type
My question: where do we store the actual value of minimum payment? Like the amount and not the type of it?
Contributor
Author
There was a problem hiding this comment.
Fixed. Ther is a minimumPaymentType and a minimumPayment for its value
budaidev
reviewed
Mar 11, 2026
|
|
||
| package org.apache.fineract.portfolio.delinquency.domain; | ||
|
|
||
| import jakarta.persistence.CascadeType; |
| package org.apache.fineract.portfolio.delinquency.domain; | ||
|
|
||
| import jakarta.persistence.Column; | ||
| import jakarta.persistence.Embedded; |
| import jakarta.persistence.UniqueConstraint; | ||
| import jakarta.persistence.Version; | ||
|
|
||
| import java.io.Serial; |
somasorosdpc
force-pushed
the
FINERACT-2455/WC-Delinquency-Management-Configuration
branch
6 times, most recently
from
6fdd005 to
4c2929a
Compare
Contributor
|
@somasorosdpc Please fix the failing checks! |
somasorosdpc
force-pushed
the
FINERACT-2455/WC-Delinquency-Management-Configuration
branch
3 times, most recently
from
67989db to
3d7e54f
Compare
Contributor
|
@somasorosdpc Please rebase |
somasorosdpc
force-pushed
the
FINERACT-2455/WC-Delinquency-Management-Configuration
branch
5 times, most recently
from
6e3725b to
557fe27
Compare
somasorosdpc
force-pushed
the
FINERACT-2455/WC-Delinquency-Management-Configuration
branch
from
557fe27 to
ff9087d
Compare
somasorosdpc
force-pushed
the
FINERACT-2455/WC-Delinquency-Management-Configuration
branch
from
ff9087d to
9fd62e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.