-
Notifications
You must be signed in to change notification settings - Fork 518
refactor: replace includeColumnIndexes list lookup with ColumnIndexResolver #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bengbengbalabalabeng
wants to merge
8
commits into
apache:main
Choose a base branch
from
bengbengbalabalabeng:refactor-columns-filter-read
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
df5c575
refactor: replace includeColumnIndexes list lookup with ColumnIndexRe…
bengbengbalabalabeng 4c6d124
style: some renaming
bengbengbalabalabeng a4e1680
Merge branch 'main' into refactor-columns-filter-read
bengbengbalabalabeng 09feb54
Merge branch 'main' into refactor-columns-filter-read
alaahong 0ed997a
Merge branch 'main' into refactor-columns-filter-read
bengbengbalabalabeng 686c947
fix: covers null element checks
bengbengbalabalabeng 72b4e03
Merge branch 'main' into refactor-columns-filter-read
bengbengbalabalabeng 35757d7
refactor: replace columns list with ColumnIndexResolver in constructor
bengbengbalabalabeng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
fesod-sheet/src/main/java/org/apache/fesod/sheet/read/metadata/ColumnIndexResolver.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.fesod.sheet.read.metadata; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import org.apache.commons.lang3.Validate; | ||
| import org.apache.fesod.common.util.MapUtils; | ||
|
|
||
| /** | ||
| * Strategy interface for column index resolution and filtering during sheet parsing. | ||
| */ | ||
| @FunctionalInterface | ||
| public interface ColumnIndexResolver { | ||
|
|
||
| /** | ||
| * Default pass-through resolver that performs no column filtering. | ||
| */ | ||
| ColumnIndexResolver PASS_THROUGH = columnIndex -> columnIndex; | ||
|
|
||
| /** | ||
| * Resolves the raw column index to a target column index. | ||
| * | ||
| * @param columnIndex raw 0-based column index | ||
| * @return mapped target column index, or {@code null} if the column is not included | ||
| */ | ||
| Integer resolve(int columnIndex); | ||
|
|
||
| static ColumnIndexResolver fromInclude(List<Integer> columnIndexes) { | ||
| return new DefaultIncludedColumnIndexResolver(columnIndexes); | ||
| } | ||
|
|
||
| class DefaultIncludedColumnIndexResolver implements ColumnIndexResolver { | ||
|
|
||
| private final Map<Integer, Integer> indexMap; | ||
|
|
||
| DefaultIncludedColumnIndexResolver(List<Integer> columnIndexes) { | ||
| Validate.notEmpty(columnIndexes, "The includeColumnIndexes must not be empty"); | ||
| Validate.noNullElements(columnIndexes, "The includeColumnIndexes must not contain null elements"); | ||
|
|
||
| List<Integer> tmpColumnIndexes = new ArrayList<>(columnIndexes); | ||
| this.indexMap = MapUtils.newHashMapWithExpectedSize(tmpColumnIndexes.size()); | ||
|
|
||
| for (int targetIndex = 0; targetIndex < tmpColumnIndexes.size(); targetIndex++) { | ||
| this.indexMap.put(tmpColumnIndexes.get(targetIndex), targetIndex); | ||
|
bengbengbalabalabeng marked this conversation as resolved.
|
||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public Integer resolve(int columnIndex) { | ||
|
bengbengbalabalabeng marked this conversation as resolved.
|
||
| return indexMap.get(columnIndex); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.