Skip to content

Conversation

@ghenzler
Copy link
Contributor

No description provided.

@ghenzler ghenzler requested a review from cziegeler January 21, 2026 18:19
@ghenzler ghenzler marked this pull request as ready for review January 23, 2026 10:09
@cziegeler
Copy link
Contributor

You could use the service reference from the service event directly to avoid reaching out to the service registry again.
Maybe we could also use a DS service reference with a target filter instead and bind/unbind methods. That should simplify the code

Copy link

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a raw service listener I would use a ServiceTracker instead what has a method getTracked() what gives you both the service and the servicereference to check the properties from or you use a customizer that holds the interesting properties in an AtomicReference.

@cziegeler
Copy link
Contributor

As this is a DS component, it is better to use DS features for service tracking, instead of going to low level framework mechanisms. (and I know I initially suggested ServiceListener, which should have been a @reference from the start)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants