fix(scatter): apply jitter on both category axes when both configured (Fixes #21728) - #21729
Open
waterWang wants to merge 1 commit into
Open
fix(scatter): apply jitter on both category axes when both configured (Fixes #21728)#21729waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21728
Problem
The jitterLayout stage only checked the base axis (returned by
getBaseAxis()) for jitter configuration. When both axes were category (ordinal) withjitterconfigured, only the base axis direction was jittered. The other axis jitter configuration was completely ignored.For example, with:
Only the x-axis jitter was applied, and the y-axis scatter points had no random offset.
Changes
In
jitterLayout.ts:coordSys.getOtherAxis()jitter > 0, apply jitter along that axis direction tooif (!hasJitter && !hasOtherJitter) return;This enables jittering on both axis directions when both axes are category with jitter configured, matching the behavior of JMP-style scatter plots where points spread in both x and y directions.
Test
Scatter plot with both category axes, each with jitter: 300, should now show random offset in both x and y directions.