fix(core): preserve event query context. close #21584#21705
Open
rahul37wallst-sudo wants to merge 1 commit into
Open
fix(core): preserve event query context. close #21584#21705rahul37wallst-sudo wants to merge 1 commit into
rahul37wallst-sudo wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Preserves mouse-event query context across nested ECharts events so handlers remain correctly filtered when an earlier handler calls
setOption.Fixed issues
seriesIdcould incorrectly run for another series after a preceding handler calledsetOption.Details
Before: What was the problem?
Mouse-event queries use
ECEventProcessor.eventInfoto determine the source series or component.When a matching handler synchronously called
setOption, ECharts emitted a nestedupdatedevent. The nested event'safterTriggerhook cleared the shared mouse-event context before the original click dispatch had finished.Consequently, later click handlers found no event context. Since missing context is treated as unfiltered, a handler registered for another series could run incorrectly:
After: How does it behave after the fixing?
The mouse-event handler now scopes
eventInfoto its dispatch:finallyblock.The unconditional
afterTriggercleanup was removed because it could clear an outer event's context during a nested trigger.As a result, synchronous nested events no longer bypass the remaining event-query filters. The context is also restored safely if an event handler throws.
A regression test verifies that:
setOption;Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/ut/spec/api/event.test.tsMerging options
Other information
Validated with:
npx jest --config test/ut/jest.config.cjs --coverage=false --runInBand --runTestsByPath test/ut/spec/api/event.test.ts TZ=UTC npm test -- --runInBand npm run checktype npm run lint npx eslint src/core/echarts.ts src/util/ECEventProcessor.ts test/ut/spec/api/event.test.ts git diff --checkThe complete unit suite passed with 26 test suites and 193 tests.