fix(treemap): align rich bottom labels. close #17591#21704
Open
rahul37wallst-sudo wants to merge 1 commit into
Open
fix(treemap): align rich bottom labels. close #17591#21704rahul37wallst-sudo wants to merge 1 commit into
rahul37wallst-sudo wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Corrects the alignment of rich treemap labels using
insideBottom,insideBottomLeft, orinsideBottomRight.Fixed issues
insideBottomLeftwere displayed at the top of their cells.Details
Before: What was the problem?
Treemap labels were always assigned the full available cell height. ZRender interprets an explicit height as the height of the entire rich-text block, so bottom-aligned rich labels kept their text tokens at the top of that block and appeared at the top of the treemap cell.
Plain-text labels were not affected in the same way.
After: How does it behave after the fixing?
Rich labels configured with
insideBottom,insideBottomLeft, orinsideBottomRightnow use their natural content height and align correctly at the bottom of the treemap cell.The change is intentionally limited to these three positions. Plain labels and rich labels at top or center positions retain their existing height constraints, minimizing unrelated visual changes.
Unit tests cover multiline labels with mixed rich and plain content, all three bottom positions, and compatibility controls for unaffected positions. A focused visual test case was also added.
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/treemap-label-position-rich.htmltest/ut/spec/series/treemap.test.tsMerging options
Other information
Validated with:
npm run lintnpm run checktype