feat: add Model Context Protocol (MCP) server with HTTP transport and authentication#1468
Open
YuZhangLarry wants to merge 1 commit into
Open
feat: add Model Context Protocol (MCP) server with HTTP transport and authentication#1468YuZhangLarry wants to merge 1 commit into
YuZhangLarry wants to merge 1 commit into
Conversation
…t and authentication ## Summary Implement Model Context Protocol (MCP) server for Dubbo Admin to enable AI integration through standardized tool interfaces. ## Key Features - **Modular Architecture**: Core components (server, registry, tools, transport, types) - **Comprehensive Tool Support**: 11 tools covering cluster info, service discovery, instance management, metrics, and application details - **Dual Transport Support**: - Stdio transport for local Claude Desktop integration - HTTP transport for remote connections with JSON-RPC 2.0 - **Security**: Optional Bearer Token authentication for HTTP endpoint ## Configuration ## Test plan - [x] Unit tests for core components - [x] Integration tests - [x] Manual testing with Claude Desktop Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
robocanic
reviewed
May 10, 2026
Contributor
robocanic
left a comment
robocanic
left a comment
There was a problem hiding this comment.
Great work! 有两个大面上需要修正的地方：
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a Model Context Protocol (MCP) server implementation for Dubbo Admin, exposing Dubbo resource operations as standardized JSON-RPC tools over both stdio (local) and HTTP (remote) transports, with optional Bearer-token authentication for the HTTP endpoint.
Changes:
- Added MCP core server, tool schemas/validation, and tool registry abstractions.
- Implemented stdio and HTTP transports (including an SSE transport variant) plus related tests.
- Added built-in MCP tools for cluster info, global search, service discovery, and detail queries; wired MCP endpoint into the console web server and extended app config with MCP settings.
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/mcp/types/validation.go | Adds required-arg validation helpers used by tool invocation. |
| pkg/mcp/types/tool.go | Defines tool schema/handler/result types for MCP tools. |
| pkg/mcp/transport/stdio/stdio.go | Implements newline-delimited JSON-RPC over stdin/stdout. |
| pkg/mcp/transport/stdio/stdio_test.go | Unit tests for stdio transport request/response handling. |
| pkg/mcp/transport/stdio/stdio_integration_test.go | End-to-end tests over in-memory pipes for stdio transport. |
| pkg/mcp/transport/http/sse.go | Adds an SSE transport implementation for streaming-like responses/events. |
| pkg/mcp/transport/http/http.go | Implements an HTTP server wrapper for MCP handling. |
| pkg/mcp/transport/http/http_test.go | Tests HTTP handler/transport behavior, CORS, concurrency, and SSE. |
| pkg/mcp/transport/http/handler.go | HTTP handler for JSON-RPC requests with basic CORS support. |
| pkg/mcp/tools/utils.go | Shared argument parsing, pagination helpers, and JSON formatting utilities. |
| pkg/mcp/tools/tools_test.go | Unit tests for tool utilities, registration, and validation helpers. |
| pkg/mcp/tools/service_discovery.go | Implements service search and service detail MCP tools. |
| pkg/mcp/tools/resource_search.go | Implements global search MCP tool with multiple search modes. |
| pkg/mcp/tools/metrics.go | Implements cluster metrics/info tool using counters. |
| pkg/mcp/tools/live_test.go | Provides optional “live” testing harness for MCP tools against real deps. |
| pkg/mcp/tools/integration_test.go | Integration-style tests for MCP server + registry + transports. |
| pkg/mcp/tools/detail_tools.go | Adds instance/app/service detail and instance search tools. |
| pkg/mcp/registry/registry.go | Implements the MCP tool registry and registrar mechanism. |
| pkg/mcp/registry/registry_test.go | Tests registry CRUD and registrar integration. |
| pkg/mcp/mcp.go | Public package facade: re-exports core types and default tool registration. |
| pkg/mcp/core/types.go | Defines JSON-RPC and MCP result types returned by the server. |
| pkg/mcp/core/tool.go | Aliases types into core and re-exports constructors/validators. |
| pkg/mcp/core/server.go | MCP server logic for initialize/tools/list/tools/call and HTTP handler glue. |
| pkg/mcp/core/server_test.go | Tests server construction, builder, and registry operations. |
| pkg/mcp/core/constants.go | Defines MCP/JSON-RPC constants and error codes. |
| pkg/mcp/core/builder.go | Adds a builder for constructing MCP servers with optional console context. |
| pkg/mcp/component.go | Adds MCP as a runtime component (currently placeholder integration). |
| pkg/core/bootstrap/init.go | Registers MCP component in bootstrap imports. |
| pkg/console/component.go | Registers MCP endpoint route and adds optional Bearer-token auth for it. |
| pkg/config/app/admin.go | Extends app config (incl. MCP config) and refactors config fields/validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+56
to
+60
| // collectClusterInfo 收集集群信息 | ||
| func collectClusterInfo(ctx consolectx.Context, mesh string) map[string]any { | ||
| counterMgr := ctx.CounterManager() | ||
| if counterMgr == nil { | ||
| return map[string]any{ |
Comment on lines
35
to
39
| type AdminConfig struct { | ||
| config.BaseConfig | ||
| // Mode in which dubbo admin is running. Available values are: "test", "global", "zone" | ||
| Mode mode.Mode `json:"mode" envconfig:"DUBBO_MODE"` | ||
| // Log configuration | ||
| Log *log.Config `json:"log" yaml:"log"` | ||
| // Diagnostics configuration |
Comment on lines
+130
to
+134
| func (c AdminConfig) Validate() error { | ||
| if c.Log == nil { | ||
| c.Log = log.DefaultLogConfig() | ||
| } else if err := c.Log.Validate(); err != nil { | ||
| return bizerror.Wrap(err, bizerror.ConfigError, "log config validation failed") |
Comment on lines
+167
to
+172
| return map[string]any{ | ||
| "keyword": keyword, | ||
| "pageSize": pageSize, | ||
| "pageNumber": pageNumber, | ||
| "applications": apps, | ||
| "totalCount": len(apps), |
| // GetServiceDetail 获取服务详情 | ||
| func GetServiceDetail(ctx consolectx.Context, args map[string]any) (*types.ToolResult, error) { | ||
| helper := NewArgsHelper(args) | ||
| serviceName := helper.GetString("serviceName", "") |
Comment on lines
+52
to
+55
| Handler: func(ctx interface{}, args map[string]any) (*core.ToolResult, error) { | ||
| msg, _ := args["message"].(string) | ||
| return core.NewTextResult("Echo: " + msg), nil | ||
| }, |
Comment on lines
+260
to
+265
| req := httptest.NewRequest("GET", "/sse", nil) | ||
| w := httptest.NewRecorder() | ||
|
|
||
| // SSE需要flusher支持，httptest.NewRecorder实现了Flusher接口 | ||
| sseTransport.HandleSSE(w, req) | ||
|
|
Comment on lines
+235
to
+239
| } | ||
| token := authHeader[7:] | ||
| if token != c.mcpAPIKey { | ||
| ctx.JSON(http.StatusUnauthorized, gin.H{"error": "Invalid API key"}) | ||
| ctx.Abort() |
Comment on lines
+139
to
+143
| handler := http.NewHandler(server) | ||
|
|
||
| // 注册MCP端点（不需要认证） | ||
| // 注意：这只是示例代码，实际注册应该在console组件中完成 | ||
| _ = handler // 避免未使用警告 |
Comment on lines
+117
to
+121
| // 通过runtime获取gin.Engine | ||
| // 这里需要一种方式来访问console组件的gin.Engine | ||
| // 暂时使用全局注册方式 | ||
| RegisterMCPRoutes(c.server, c.cfg.Path) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement Model Context Protocol (MCP) server for Dubbo Admin to enable AI integration through standardized tool interfaces. This allows AI assistants (like Claude) to directly interact with Dubbo resources.
Architecture
Core Components
pkg/mcp/core/): MCP protocol implementation with JSON-RPC 2.0pkg/mcp/registry/): Tool registration and managementpkg/mcp/tools/): 11 tools for Dubbo resource operationspkg/mcp/transport/): Stdio and HTTP transport layerspkg/mcp/types/): Request/response schemas and validationTransport Layers
Tool Categories
get_cluster_info,global_searchsearch_services,get_service_detail,get_service_instancessearch_instances,get_instance_detail,get_instance_metricsget_application_detail,get_application_instances,get_application_servicesConfiguration