fix: address website dependency vulnerabilities - #19814
Conversation
|
The failing |
There was a problem hiding this comment.
Pull request overview
Updates the documentation website’s npm dependency graph to remediate Dependabot-reported vulnerabilities by pinning select transitive packages via npm overrides and regenerating website/package-lock.json accordingly. This aligns the committed lockfile with a patched set of transitive versions without affecting Druid runtime or the web-console.
Changes:
- Add npm
overridesinwebsite/package.jsonto force patched transitive versions (brace-expansion,serialize-javascript,sockjs→uuid,tmp). - Refresh
website/package-lock.jsonto the updated resolved dependency graph. - Update website CI install step to use
npm ciin.github/scripts/web-checks.sh.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
website/package.json |
Adds targeted npm overrides to pin vulnerable transitive packages to patched versions. |
website/package-lock.json |
Regenerates the lockfile to reflect the overridden/patched transitive dependency graph. |
.github/scripts/web-checks.sh |
Switches website install step to npm ci for reproducible CI installs. |
Files not reviewed (1)
- website/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- website/package-lock.json: Generated file
Comments suppressed due to low confidence (1)
.github/scripts/web-checks.sh:30
npx --yes npm@10.8.2 ciinstalls the lockfile with the pinned npm version, but the subsequentnpm run ...commands will use whatevernpmis onPATH(currentlyweb-console's frontend-maven-plugin installs npm 10.9.0). For reproducibility and to keep the website build checks aligned with the lockfile generator, run the build/link-lint/spellcheck steps via the same pinned npm as well.
(cd website && npx --yes npm@10.8.2 ci)
cd website
npm run build
npm run link-lint
npm run spellcheck
Dependency
Depends on #19788 and must be merged after #19788.
This is a stacked PR based on #19788 head commit
65630f6ab7100e1e82f160054d90dd502a2d1b7b. Its website dependency changes assume the Docusaurus and Node.js updates from that PR.Changes
brace-expansion5.0.8serialize-javascript7.0.5sockjs'suuid11.1.1tmp0.2.7website/package-lock.jsonwith the repository-pinned npm 10.8.2.This covers all 50 currently open Dependabot alerts for
website/package-lock.json, spanning 27 packages. A range-by-range check against the GitHub alert metadata found zero installed versions within any reported vulnerable range.The change only affects the documentation website dependency graph. It does not change Druid runtime or web-console dependencies.
Validation
npx --yes npm@10.8.2 cinpm ls --all --omit=optionalnpm run buildnpm run link-lintnpm run spellcheck(264 files)The production build succeeds with the existing broken-anchor warnings.
Attribution
This pull request was created by GPT-5.6-Sol.