refactor: split out PhysicalSegmentColumnInspector from PhysicalSegmentInspector#19577
Open
clintropolis wants to merge 1 commit into
Open
refactor: split out PhysicalSegmentColumnInspector from PhysicalSegmentInspector#19577clintropolis wants to merge 1 commit into
clintropolis wants to merge 1 commit into
Conversation
github-actions
Bot
added
Area - Batch Ingestion
Area - Segment Format and Ser/De
Area - MSQ
FrankChen021
left a comment
FrankChen021
left a comment
Member
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
Reviewed 12 of 12 changed files.
This is an automated review by Codex GPT-5.5
capistrant
approved these changes
Jun 12, 2026
| Comparable getMinValue(String column); | ||
|
|
||
| /** | ||
| * Returns the minimum value of the provided column, if known through an index, dictionary, or cache. Returns null |
Contributor
There was a problem hiding this comment.
Suggested change
| * Returns the minimum value of the provided column, if known through an index, dictionary, or cache. Returns null | |
| * Returns the maximum value of the provided column, if known through an index, dictionary, or cache. Returns null |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small change to split out a new
PhysicalSegmentColumnInspectorfromPhysicalSegmentInspectorthat takes all of the column specific methods (and theColumnInspectorpart) to assist the partial load functionality I have been working on, since the methods I have moved toPhysicalSegmentColumnInspectorcurrently at least need the actual column present to correctly implement, however the remaining methods inPhysicalSegmentInspectorcan be answered purely with metadata.PhysicalSegmentColumnInspectoris only used bySegmentAnalyzerfor segment metadata queries for column analysis, so I think this change shouldn't be very disruptive, as the wider used methods like row count and metadata retrieval remain on the existing interface.