build(deps): Upgrade SpotBugs to 4.9.3#19576
Open
amaechler wants to merge 3 commits into
Open
Conversation
amaechler
changed the title
FrankChen021
left a comment
FrankChen021
left a comment
Member
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
Reviewed 4 of 4 changed files.
This is an automated review by Codex GPT-5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18373.
I came across @kgyrtkirk's issue above (#18373) which was auto-closed. Addressing the few spotbug warnings was straight-forward, especially with Claude doing all the work. This PR removes the pin so the plugin's matching default, 4.9.3, is used.
SpotBugs 4.9 ships some new "detectors". Running
mvn spotbugs:checkover all modules produced 17 new findings, handled as follows:AT_*atomicity patterns inspotbugs-exclude.xml, alongside the already-excludedAT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION. The flagged sites rely on external synchronization.HSM_HIDING_METHOD.InvalidSqlInputhides the staticInvalidInput.exception()factory methods by design.@SuppressFBWarningsannotations that the newUselessSuppressionDetectorreports as unnecessary.This PR has: