Skip to content

Remove dependency jackson-mapper-asl:1.9.13 which has lots of CVEs - #18456

Closed
FrankChen021 wants to merge 5 commits into
apache:masterfrom
FrankChen021:dependency
Closed

Remove dependency jackson-mapper-asl:1.9.13 which has lots of CVEs#18456
FrankChen021 wants to merge 5 commits into
apache:masterfrom
FrankChen021:dependency

Conversation

@FrankChen021

Copy link
Copy Markdown
Member

Description

This dependency has lots of critical CVEs, and these CVEs have been suppressed since #9604 and before.

image

Our internal tool constantly reports this problem, So I remove this dependency after I find that it's not used anymore.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@FrankChen021

Copy link
Copy Markdown
Member Author

is there sth wrong with CVE check?

Error:  Failed to execute goal org.owasp:dependency-check-maven:7.4.4:check (default-cli) on project druid: Fatal exception(s) analyzing Druid: One or more exceptions occurred during analysis:
Error:  	UpdateException: Unable to download meta file: https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta
Error:  		caused by DownloadFailedException: Download failed, unable to retrieve 'https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta'; Error downloading file https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; unable to connect.
Error:  		caused by DownloadFailedException: Error downloading file https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; unable to connect.
Error:  		caused by DownloadFailedException: Error retrieving https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; received response code 403; Forbidden
Error:  	NoDataException: No documents exist

@github-actions github-actions Bot added the GHA label Sep 5, 2025
@FrankChen021

Copy link
Copy Markdown
Member Author
[INFO] --- dependency-check:12.1.3:check (default-cli) @ druid ---
[INFO] Checking for updates
Warning:  An NVD API Key was not provided - it is highly recommended to use an NVD API key as the update can take a VERY long time without an API Key

will take a look later

@FrankChen021

Copy link
Copy Markdown
Member Author

Superseded by #19808, which provides the current, narrower replacement: it removes both jackson-core-asl and jackson-mapper-asl, removes the unused Jackson 1 dependency-management entries and version property, and drops the obsolete OWASP suppression without carrying forward the unrelated historical CI workflow changes. Closing this older PR in favor of #19808.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants