branch-4.1: [fix](recycler) skip packed slice deletion during recycle rowsets#65533
branch-4.1: [fix](recycler) skip packed slice deletion during recycle rowsets#65533wyxxxcat wants to merge 1 commit into
Conversation
|
run buildall |
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automated review completed for PR 65533.
I reviewed the packed-slice delete suppression in both delete_rowset_data paths, the packed-file reference count flow, V1/V2 inverted index handling, delete-bitmap interaction, empty delete-list behavior, and the updated recycler tests. I did not find a PR-introduced correctness issue to raise inline.
Subagent review converged in round 2 with NO_NEW_VALUABLE_FINDINGS after the main-agent verification dismissed all proposed candidates. No existing inline review threads were present, and there was no additional user-provided review focus.
Validation limits: static review only, per the prompt. I did not run builds or tests. A local git diff --check HEAD~1 HEAD whitespace check was not possible because this shallow checkout only contains the PR head commit and lacks the base/parent commit.
1 participant
pick: #63295