branch-4.0: [fix](fe) Fix colocate replica allocation edit log #65457#65528
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](fe) Fix colocate replica allocation edit log #65457#65528github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Related PR: #49569 Problem Summary: Related PR #49569 changed the colocate replica allocation helper boolean from needEditLog to isReplay, but kept the old call-site values. As a result, normal ALTER COLOCATE GROUP replica allocation changes were treated as replay and skipped logColocateModifyRepliaAlloc, so the new replica allocation was not persisted for follower replay or master failover. The replay path was treated as a normal operation and could append another edit log while loading journal entries. This patch flips the two call-site values: leader ALTER uses isReplay = false and writes the edit log, while replay uses isReplay = true and does not append a new edit log. It also adds FE unit tests covering both behaviors.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #65457