[fix](regression) stabilize MTMV SQL cache refresh checks#65527
Draft
shuke987 wants to merge 1 commit into
Draft
[fix](regression) stabilize MTMV SQL cache refresh checks#65527shuke987 wants to merge 1 commit into
shuke987 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
Review complete for head 4aa5619f5e61b242d42304f6f4072e10075a9378. I did not find a blocking issue or a substantiated inline finding.
Checkpoint conclusions:
- Goal and coverage: the PR stabilizes one regression assertion after
INSERT OVERWRITEplusREFRESH MATERIALIZED VIEW ... AUTO. The changed block still checks direct MTMV cache invalidation, still checks nested rewrite cache invalidation, verifies the refreshed MTMV is chosen with SQL cache disabled, and compares cache-enabled vs cache-disabled results. - Scope: the change is small and focused to one regression-test assertion block.
- Concurrency, lifecycle, config, compatibility, persistence, FE/BE protocol, data-write behavior, and observability: not applicable to this regression-only change.
- Parallel paths: checked the nearby AUTO refresh, complete refresh, add-partition/base-insert, and add-column branches in the same suite; I did not find a missed analogous assertion change.
- Session state:
mv_rewrite_successchecks the memo plan contains the refreshed MV choice, andjudge_resrestoresenable_sql_cache=trueplusenable_strong_consistency_read=truebefore later cache assertions. - Test result files: no
.outfiles are changed. I did not run the regression suite in this review-only checkout;.worktree_initializedandthirdparty/installedare missing. - User focus: no additional user-provided review focus was present.
Round 1 full-review and risk-focused subagents both returned NO_NEW_VALUABLE_FINDINGS; the main risk scan items were dismissed with code evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: #57177
Problem Summary:
mtmv_with_sql_cacheintermittently requiredmtmv_sql1to miss SQL cache after refreshingmv_name1. However, the case rebuilt that cache afterINSERT OVERWRITEwhile the MTMV was stale. The cached physical plan could therefore scan only the two base tables. Refreshing the MTMV did not change either recorded base-table version, so retaining that cache entry was valid.This change removes only that invalid cache-residency assumption while preserving the original test coverage:
mtmv_sql1rewrite;The failure was observed in P0 build 992833, occurrence 2000001579, with the same original line 768 and base-table
PhysicalSqlCacheplan seen in earlier muted failures.Release note
None
Check List (For Author)
Test
git diff --checkmv_rewrite_successbypasses SQL cache here and checks.<mv_name> chosethrough the existing memo-plan helper.Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)