-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[fix](transaction) Fail fast when a backend restarts during insert #65525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
fe/fe-core/src/test/java/org/apache/doris/qe/runtime/SingleFragmentPipelineTaskTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.qe.runtime; | ||
|
|
||
| import org.apache.doris.common.Status; | ||
| import org.apache.doris.system.Backend; | ||
| import org.apache.doris.thrift.TStatusCode; | ||
| import org.apache.doris.thrift.TUniqueId; | ||
|
|
||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.util.Collections; | ||
|
|
||
| class SingleFragmentPipelineTaskTest { | ||
| @Test | ||
| void backendWithUnchangedProcessEpochIsHealthy() { | ||
| Backend backend = createBackend(100L); | ||
| SingleFragmentPipelineTask task = createTask(backend); | ||
|
|
||
| Assertions.assertTrue(task.getBackendHealthStatus(-1L).ok()); | ||
| } | ||
|
|
||
| @Test | ||
| void backendRestartIsUnhealthyEvenWhenBackendIsAlive() { | ||
| Backend backend = createBackend(100L); | ||
| SingleFragmentPipelineTask task = createTask(backend); | ||
|
|
||
| backend.setLastStartTime(200L); | ||
|
|
||
| Status status = task.getBackendHealthStatus(-1L); | ||
| Assertions.assertEquals(TStatusCode.INTERNAL_ERROR, status.getErrorCode()); | ||
| Assertions.assertEquals( | ||
| "backend 1 process epoch changed from 100 to 200, indicating that the backend restarted", | ||
| status.getErrorMsg()); | ||
| } | ||
|
|
||
| @Test | ||
| void zeroCurrentProcessEpochIsIgnoredForCompatibility() { | ||
| Backend backend = createBackend(100L); | ||
| SingleFragmentPipelineTask task = createTask(backend); | ||
|
|
||
| backend.setLastStartTime(0L); | ||
|
|
||
| Assertions.assertTrue(task.getBackendHealthStatus(-1L).ok()); | ||
| } | ||
|
|
||
| @Test | ||
| void zeroCapturedProcessEpochIsIgnoredForCompatibility() { | ||
| Backend backend = createBackend(0L); | ||
| SingleFragmentPipelineTask task = createTask(backend); | ||
|
|
||
| backend.setLastStartTime(100L); | ||
|
|
||
| Assertions.assertTrue(task.getBackendHealthStatus(-1L).ok()); | ||
| } | ||
|
|
||
| @Test | ||
| void backendDownAfterMissingHeartbeatIsUnhealthy() { | ||
| Backend backend = createBackend(100L); | ||
| SingleFragmentPipelineTask task = createTask(backend); | ||
|
|
||
| backend.setLastMissingHeartbeatTime(1L); | ||
| backend.setAlive(false); | ||
|
|
||
| Status status = task.getBackendHealthStatus(-1L); | ||
| Assertions.assertEquals(TStatusCode.INTERNAL_ERROR, status.getErrorCode()); | ||
| Assertions.assertEquals("backend 1 is down", status.getErrorMsg()); | ||
| } | ||
|
|
||
| private static Backend createBackend(long processEpoch) { | ||
| Backend backend = new Backend(1L, "127.0.0.1", 9050); | ||
| backend.setAlive(true); | ||
| backend.setLastStartTime(processEpoch); | ||
| return backend; | ||
| } | ||
|
|
||
| private static SingleFragmentPipelineTask createTask(Backend backend) { | ||
| return new SingleFragmentPipelineTask(backend, 0, Collections.<TUniqueId>emptySet()); | ||
| } | ||
| } |
128 changes: 128 additions & 0 deletions
128
regression-test/suites/load_p0/insert/test_insert_fail_fast_after_be_restart.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| import org.apache.doris.regression.suite.ClusterOptions | ||
|
|
||
| import java.util.concurrent.TimeUnit | ||
|
|
||
| suite("test_insert_fail_fast_after_be_restart", "docker") { | ||
| def options = new ClusterOptions() | ||
| options.enableDebugPoints() | ||
| options.setFeNum(1) | ||
| options.setBeNum(1) | ||
| options.cloudMode = false | ||
| // Keep the BE logically alive during restart so the test exercises the process-epoch branch, | ||
| // rather than the existing backend-down branch. | ||
| options.feConfigs += ["max_backend_heartbeat_failure_tolerance_count=100"] | ||
|
|
||
| docker(options) { | ||
| GetDebugPoint().clearDebugPointsForAllBEs() | ||
|
|
||
| try { | ||
| sql "DROP TABLE IF EXISTS test_insert_fail_fast_after_be_restart" | ||
| sql """ | ||
| CREATE TABLE test_insert_fail_fast_after_be_restart ( | ||
| k BIGINT NOT NULL, | ||
| v BIGINT NOT NULL | ||
| ) | ||
| DUPLICATE KEY(k) | ||
| DISTRIBUTED BY HASH(k) BUCKETS 1 | ||
| PROPERTIES ( | ||
| "replication_num" = "1" | ||
| ) | ||
| """ | ||
|
|
||
| def backendBeforeRestart = sql_return_maparray("SHOW BACKENDS")[0] | ||
| def backendId = backendBeforeRestart.BackendId.toString() | ||
| def previousLastStartTime = backendBeforeRestart.LastStartTime.toString() | ||
| assertTrue(backendBeforeRestart.Alive.toString().equalsIgnoreCase("true")) | ||
|
|
||
| // Hold the load fragment before it can report completion to FE. Restarting the BE | ||
| // at this point drops that report while the replacement process quickly becomes alive. | ||
| def debugPointToken = "insert_restart_${System.nanoTime()}" | ||
| def debugPointParams = [sleep_sec: 300, token: debugPointToken] | ||
| GetDebugPoint().enableDebugPointForAllBEs("VTabletWriter.close.sleep", debugPointParams) | ||
| GetDebugPoint().enableDebugPointForAllBEs("VTabletWriterV2.close.sleep", debugPointParams) | ||
|
|
||
| def insertFuture = thread { | ||
| sql "SET enable_nereids_planner = true" | ||
| sql "SET enable_fallback_to_original_planner = false" | ||
| sql "SET insert_timeout = 300" | ||
| try { | ||
| sql """ | ||
| INSERT INTO test_insert_fail_fast_after_be_restart | ||
| SELECT number, number FROM numbers("number" = "1024") | ||
| """ | ||
| return null | ||
| } catch (Throwable t) { | ||
| logger.info("INSERT failed after BE restart as expected: ${t.message}") | ||
| return t.message | ||
| } | ||
| } | ||
|
|
||
| def beLogFile = new File(cluster.getBeByIndex(1).getLogFilePath()) | ||
| def debugPointMarkers = [ | ||
| "hit debug point VTabletWriter.close.sleep, token=${debugPointToken}", | ||
| "hit debug point VTabletWriterV2.close.sleep, token=${debugPointToken}" | ||
| ] | ||
| def waitDeadline = System.nanoTime() + TimeUnit.SECONDS.toNanos(60) | ||
| def debugPointHit = false | ||
| while (System.nanoTime() < waitDeadline) { | ||
| if (beLogFile.exists()) { | ||
| def beLog = beLogFile.text | ||
| if (debugPointMarkers.any { beLog.contains(it) }) { | ||
| debugPointHit = true | ||
| break | ||
| } | ||
| } | ||
| sleep(200) | ||
| } | ||
| assertTrue(debugPointHit, "INSERT did not reach the writer close debug point") | ||
|
|
||
| cluster.restartBackends() | ||
|
sollhui marked this conversation as resolved.
|
||
|
|
||
| def restartedBackendObserved = false | ||
| def heartbeatDeadline = System.nanoTime() + TimeUnit.SECONDS.toNanos(60) | ||
| while (System.nanoTime() < heartbeatDeadline) { | ||
| def currentBackend = sql_return_maparray("SHOW BACKENDS") | ||
| .find { it.BackendId.toString() == backendId } | ||
| if (currentBackend != null | ||
| && currentBackend.Alive.toString().equalsIgnoreCase("true") | ||
| && currentBackend.LastStartTime.toString() != previousLastStartTime) { | ||
| restartedBackendObserved = true | ||
| break | ||
| } | ||
| sleep(200) | ||
| } | ||
| assertTrue(restartedBackendObserved, | ||
| "FE did not observe the restarted BE as alive with a changed process epoch") | ||
|
|
||
| // LoadProcessor checks backend health every 30 seconds. The restarted BE is alive, | ||
| // so this only finishes before insert_timeout when FE also compares process epochs. | ||
| def errorMessage = insertFuture.get(60, TimeUnit.SECONDS) | ||
|
sollhui marked this conversation as resolved.
|
||
| assertNotNull(errorMessage, "INSERT should fail after its BE process restarts") | ||
| assertTrue(errorMessage.contains("process epoch changed"), | ||
| "unexpected INSERT error after BE restart: ${errorMessage}") | ||
| assertTrue(errorMessage.contains("backend restarted"), | ||
| "INSERT error should explain that the backend restarted: ${errorMessage}") | ||
|
|
||
| assertEquals(0, sql("SELECT COUNT(*) FROM test_insert_fail_fast_after_be_restart")[0][0] as int) | ||
| } finally { | ||
| GetDebugPoint().clearDebugPointsForAllBEs() | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.