[feature](s3) Support S3 Express One Zone#65504
Open
0AyanamiRei wants to merge 3 commits into
Open
Conversation
…nt-MD5 for S3 Express
### What problem does this PR solve?\n\nIssue Number: close #xxx\n\nRelated PR: apache#63409\n\nProblem Summary: The initial S3 Express implementation detected directory buckets and endpoints with broad substring matches in two separate locations. This could classify ordinary bucket names or endpoint paths as S3 Express and allowed the client configuration and upload checksum behavior to diverge. Centralize the decision in one helper, require the documented --x-s3 bucket suffix or an s3express endpoint host label, and pass the resulting context into the object storage client. Add unit coverage for valid and invalid names.\n\n### Release note\n\nNone\n\n### Check List (For Author)\n\n- Test: Unit Test (S3UTILTest.is_s3_express_context; ASAN UT rebuild started)\n- Behavior changed: No, except avoiding false-positive S3 Express detection\n- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #63409
Problem Summary:
Doris cannot currently read from or write to Amazon S3 Express One Zone directory buckets.
There are two compatibility gaps:
CreateSessionauthentication, and thes3expresssigning service.Content-MD5forPutObjectandUploadPart. S3 Express One Zone does not supportContent-MD5for these requests and requires a flexible checksum such as CRC32C.This PR takes over and supersedes #63409. It:
Aws::S3::S3ClientConfigurationandS3EndpointProviderso AWS endpoint rules and S3 Express session authentication are enabled.Content-MD5for S3 Express uploads, while preserving the existing MD5 behavior for regular S3 and S3-compatible endpoints.s3_disable_content_md5as an explicit compatibility switch for endpoints that do not supportContent-MD5.--x-s3, and endpoints must contain an S3 Express hostname label rather than an arbitrary substring.Release note
Support reading from and writing to Amazon S3 Express One Zone directory buckets. S3 Express uploads use CRC32C instead of
Content-MD5.Check List (For Author)
Test
Behavior changed:
PutObjectandUploadPartuse CRC32C instead ofContent-MD5in the S3 Express context.Does this need documentation?
Check List (For Reviewer who merge this PR)